sync/internal_api/attachments/fake_attachment_downloader.cc - Issue 982883002: [Sync] Add size and crc32c to AttachmentId.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/attachments/fake_attachment_downloader.cc

Issue 982883002: [Sync] Add size and crc32c to AttachmentId. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix argument evaluation order bug. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sync/internal_api/attachments/fake_attachment_downloader.cc

diff --git a/sync/internal_api/attachments/fake_attachment_downloader.cc b/sync/internal_api/attachments/fake_attachment_downloader.cc

index 53abc61da11ca18381381e3f7de83c0ce02d2589..299c4184287ff8eabb82bb96265a668a0fd54969 100644

--- a/sync/internal_api/attachments/fake_attachment_downloader.cc

+++ b/sync/internal_api/attachments/fake_attachment_downloader.cc

@@ -25,9 +25,8 @@ void FakeAttachmentDownloader::DownloadAttachment(

// attachment.

scoped_refptr<base::RefCountedMemory> data(new base::RefCountedBytes());

scoped_ptr<Attachment> attachment;

- const uint32_t crc32c = ComputeCrc32c(data);

attachment.reset(

- new Attachment(Attachment::CreateFromParts(attachment_id, data, crc32c)));

+ new Attachment(Attachment::CreateFromParts(attachment_id, data)));

base::MessageLoop::current()->PostTask(

FROM_HERE,

base::Bind(callback, DOWNLOAD_SUCCESS, base::Passed(&attachment)));