sync/internal_api/attachments/attachment_store_test_template.h - Issue 982883002: [Sync] Add size and crc32c to AttachmentId.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/attachments/attachment_store_test_template.h

Issue 982883002: [Sync] Add size and crc32c to AttachmentId. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix argument evaluation order bug. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sync/internal_api/attachments/attachment_store_test_template.h

diff --git a/sync/internal_api/attachments/attachment_store_test_template.h b/sync/internal_api/attachments/attachment_store_test_template.h

index 290ef220573747d59d76dcc7827e1090dbe8d25d..4a8e17481ba3b59a291b5f3b93c8b994994436ba 100644

--- a/sync/internal_api/attachments/attachment_store_test_template.h

+++ b/sync/internal_api/attachments/attachment_store_test_template.h

@@ -135,7 +135,7 @@ TYPED_TEST_P(AttachmentStoreTest, Write_NoOverwriteNoError) {

Attachment attachment1 = Attachment::Create(this->some_data1);

uint32_t crc32c = ComputeCrc32c(this->some_data2);

Attachment attachment2 = Attachment::CreateFromParts(

- attachment1.GetId(), this->some_data2, crc32c);

+ AttachmentId::Create(this->some_data2->size(), crc32c), this->some_data2);

pavely 2015/03/07 00:07:25 Restore the spirit. Discussed in person.

maniscalco 2015/03/09 17:09:00 Done.

// Write the first one.

AttachmentList some_attachments;