[Sync] Add size and crc32c to AttachmentId.

sync/internal_api/attachments/attachment_store_test_template.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef SYNC_INTERNAL_API_ATTACHMENTS_ATTACHMENT_STORE_TEST_TEMPLATE_H_
 #define SYNC_INTERNAL_API_ATTACHMENTS_ATTACHMENT_STORE_TEST_TEMPLATE_H_
 
 #include "sync/api/attachments/attachment_store.h"
 
 #include "base/bind.h"
@@ skipping 117 matching lines @@
 
 TYPED_TEST_CASE_P(AttachmentStoreTest);
 
 // Verify that we do not overwrite existing attachments and that we do not treat
 // it as an error.
 TYPED_TEST_P(AttachmentStoreTest, Write_NoOverwriteNoError) {
   // Create two attachments with the same id but different data.
   Attachment attachment1 = Attachment::Create(this->some_data1);
   uint32_t crc32c = ComputeCrc32c(this->some_data2);
   Attachment attachment2 = Attachment::CreateFromParts(
-      attachment1.GetId(), this->some_data2, crc32c);
+      AttachmentId::Create(this->some_data2->size(), crc32c), this->some_data2);

[pavely, 2015/03/07 00:07:25]

Restore the spirit. Discussed in person.

[maniscalco, 2015/03/09 17:09:00]

Done.

 
   // Write the first one.
   AttachmentList some_attachments;
   some_attachments.push_back(attachment1);
   this->store->Write(some_attachments, this->write_callback);
   this->ClearAndPumpLoop();
   EXPECT_EQ(AttachmentStore::SUCCESS, this->result);
 
   // Write the second one.
   some_attachments.clear();
@@ skipping 242 matching lines @@
                            Write_RoundTrip,
                            Read_OneNotFound,
                            Drop_DropTwoButOnlyOneExists,
                            Drop_DoesNotExist,
                            ReadMetadata,
                            ReadAllMetadata);
 
 }  // namespace syncer
 
 #endif  // SYNC_INTERNAL_API_ATTACHMENTS_ATTACHMENT_STORE_TEST_TEMPLATE_H_