Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(858)

Issue 982563002: Removing WebRTC Java API (Closed)

Created:
5 years, 9 months ago by mnaganov (inactive)
Modified:
5 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removing WebRTC Java API It's not used any longer. Was added in https://codereview.chromium.org/551793003/ as temporary solution to use WebRTC from android service. In following CLs we've moved to native API: https://codereview.chromium.org/704613003 https://codereview.chromium.org/716433003 https://codereview.chromium.org/719043002 https://codereview.chromium.org/734313002 There is no plan to use Java API for DevTools bridge again. BUG=383418 Committed: https://crrev.com/807b0d3e36f995ebee66c3abd927c25b8008f920 Cr-Commit-Position: refs/heads/master@{#319106}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -66 lines) Patch
M third_party/libjingle/BUILD.gn View 1 chunk +0 lines, -37 lines 0 comments Download
M third_party/libjingle/libjingle.gyp View 1 chunk +0 lines, -29 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mnaganov (inactive)
This is a rebase of https://codereview.chromium.org/767073002/ . As I'm not the owner of the CL, ...
5 years, 9 months ago (2015-03-04 16:05:02 UTC) #2
kjellander_chromium
lgtm, thanks for finishing this cleanup. IMO such targets should belong in the libjingle code ...
5 years, 9 months ago (2015-03-04 17:40:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/982563002/1
5 years, 9 months ago (2015-03-04 17:45:14 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-04 19:50:51 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 19:51:39 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/807b0d3e36f995ebee66c3abd927c25b8008f920
Cr-Commit-Position: refs/heads/master@{#319106}

Powered by Google App Engine
This is Rietveld 408576698