Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 734313002: Switching to native implementation of SessionDependencyFactory. (Closed)

Created:
6 years, 1 month ago by SeRya
Modified:
6 years, 1 month ago
CC:
chromium-reviews, vsevik, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@native-factory-3
Project:
chromium
Visibility:
Public.

Description

Switching to native implementation of SessionDependencyFactory. Since SessionDependencyFactory is ready to use Java implementation is not needed longer. BUG=383418 Committed: https://crrev.com/16cb55751cee80d4ac957130d3b991c219812eb0 Cr-Commit-Position: refs/heads/master@{#304668}

Patch Set 1 #

Patch Set 2 : #

Messages

Total messages: 11 (4 generated)
SeRya
PTAL. It's based on unlanded https://codereview.chromium.org/734313002/
6 years, 1 month ago (2014-11-18 07:09:59 UTC) #2
mnaganov (inactive)
lgtm
6 years, 1 month ago (2014-11-18 16:43:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/734313002/1
6 years, 1 month ago (2014-11-18 18:19:16 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/23165)
6 years, 1 month ago (2014-11-18 18:54:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/734313002/20001
6 years, 1 month ago (2014-11-18 19:54:52 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-18 21:21:15 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-11-18 21:22:08 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/16cb55751cee80d4ac957130d3b991c219812eb0
Cr-Commit-Position: refs/heads/master@{#304668}

Powered by Google App Engine
This is Rietveld 408576698