Beginning implementation of SessionDependencyFactory.

Beginning implementation of SessionDependencyFactory.

As we discussed in the email thread DevTools Bridge must not depend on libjingle_peerconnection_so.so
for several reasons. To aheive that we need implementation of SessionDependencyFactory
on top of libjingle's C++ API. This CL adds dummy SessionDependencyFactoryNative and
introduces additional test APK. Both testing APKs will coexist for a while. When
SessionDependencyFactoryNative be ready to replace Java API counterpart additional APK
also won't be needed.

BUG=383418
Committed: https://crrev.com/3c76b33f9d02ffc9b386cbbd0351e9957fd8ef66
Cr-Commit-Position: refs/heads/master@{#303421}

[SeRya, 2014-11-05 17:21:11]

serya@chromium.org changed reviewers:
+ glaznev@chromium.org, mnaganov@chromium.org

[SeRya, 2014-11-05 18:17:07]

Patchset #1 (id:1) has been deleted

[SeRya, 2014-11-05 18:58:28]

PTAL

[mnaganov (inactive), 2014-11-05 22:38:49]

LGTM % style nits

https://codereview.chromium.org/704613003/diff/40001/components/devtools_brid...
File components/devtools_bridge/android/session_dependency_factory_native.cc
(right):

https://codereview.chromium.org/704613003/diff/40001/components/devtools_brid...
components/devtools_bridge/android/session_dependency_factory_native.cc:1: //
Copyright (c) 2014 The Chromium Authors. All rights reserved.
nit: remove "(c)"

https://codereview.chromium.org/704613003/diff/40001/components/devtools_brid...
components/devtools_bridge/android/session_dependency_factory_native.cc:10:
namespace android {
nit: please add an empty line before the anonymous namespace

https://codereview.chromium.org/704613003/diff/40001/components/devtools_brid...
components/devtools_bridge/android/session_dependency_factory_native.cc:31:
return reinterpret_cast<jlong>(new SessionDependencyFactoryNative());
nit: wrong indentation

https://codereview.chromium.org/704613003/diff/40001/components/devtools_brid...
components/devtools_bridge/android/session_dependency_factory_native.cc:35:
delete SessionDependencyFactoryNative::cast(ptr);
nit: wrong indentation

https://codereview.chromium.org/704613003/diff/40001/components/devtools_brid...
File components/devtools_bridge/android/session_dependency_factory_native.h
(right):

https://codereview.chromium.org/704613003/diff/40001/components/devtools_brid...
components/devtools_bridge/android/session_dependency_factory_native.h:1: //
Copyright (c) 2014 The Chromium Authors. All rights reserved.
nit: remove "(c)"

https://codereview.chromium.org/704613003/diff/40001/components/devtools_brid...
components/devtools_bridge/android/session_dependency_factory_native.h:5:
#ifndef COMPONENTS_DEVTOOLS_BRIDGE_ANDROID_SESSION_DEPENDENCY_FACTORY_NAITIVE_H_
typo: NAITIVE

https://codereview.chromium.org/704613003/diff/40001/components/devtools_brid...
components/devtools_bridge/android/session_dependency_factory_native.h:20:
~SessionDependencyFactoryNative();
nit: wrong indentation

https://codereview.chromium.org/704613003/diff/40001/components/devtools_brid...
File components/devtools_bridge/test/android/javatests/jni/jni_onload.cc
(right):

https://codereview.chromium.org/704613003/diff/40001/components/devtools_brid...
components/devtools_bridge/test/android/javatests/jni/jni_onload.cc:1: //
Copyright (c) 2012 The Chromium Authors. All rights reserved.
2014

[SeRya, 2014-11-06 06:42:46]

https://codereview.chromium.org/704613003/diff/40001/components/devtools_brid...
File components/devtools_bridge/android/session_dependency_factory_native.cc
(right):

https://codereview.chromium.org/704613003/diff/40001/components/devtools_brid...
components/devtools_bridge/android/session_dependency_factory_native.cc:1: //
Copyright (c) 2014 The Chromium Authors. All rights reserved.
On 2014/11/05 22:38:49, mnaganov (cr) wrote:
> nit: remove "(c)"

Done.

https://codereview.chromium.org/704613003/diff/40001/components/devtools_brid...
components/devtools_bridge/android/session_dependency_factory_native.cc:10:
namespace android {
On 2014/11/05 22:38:49, mnaganov (cr) wrote:
> nit: please add an empty line before the anonymous namespace

Done.

https://codereview.chromium.org/704613003/diff/40001/components/devtools_brid...
components/devtools_bridge/android/session_dependency_factory_native.cc:31:
return reinterpret_cast<jlong>(new SessionDependencyFactoryNative());
On 2014/11/05 22:38:49, mnaganov (cr) wrote:
> nit: wrong indentation

Done.

https://codereview.chromium.org/704613003/diff/40001/components/devtools_brid...
components/devtools_bridge/android/session_dependency_factory_native.cc:35:
delete SessionDependencyFactoryNative::cast(ptr);
On 2014/11/05 22:38:49, mnaganov (cr) wrote:
> nit: wrong indentation

Done.

https://codereview.chromium.org/704613003/diff/40001/components/devtools_brid...
File components/devtools_bridge/android/session_dependency_factory_native.h
(right):

https://codereview.chromium.org/704613003/diff/40001/components/devtools_brid...
components/devtools_bridge/android/session_dependency_factory_native.h:1: //
Copyright (c) 2014 The Chromium Authors. All rights reserved.
On 2014/11/05 22:38:49, mnaganov (cr) wrote:
> nit: remove "(c)"

Done.

https://codereview.chromium.org/704613003/diff/40001/components/devtools_brid...
components/devtools_bridge/android/session_dependency_factory_native.h:5:
#ifndef COMPONENTS_DEVTOOLS_BRIDGE_ANDROID_SESSION_DEPENDENCY_FACTORY_NAITIVE_H_
On 2014/11/05 22:38:49, mnaganov (cr) wrote:
> typo: NAITIVE

Done.

https://codereview.chromium.org/704613003/diff/40001/components/devtools_brid...
components/devtools_bridge/android/session_dependency_factory_native.h:20:
~SessionDependencyFactoryNative();
On 2014/11/05 22:38:49, mnaganov (cr) wrote:
> nit: wrong indentation

Done.

https://codereview.chromium.org/704613003/diff/40001/components/devtools_brid...
File components/devtools_bridge/test/android/javatests/jni/jni_onload.cc
(right):

https://codereview.chromium.org/704613003/diff/40001/components/devtools_brid...
components/devtools_bridge/test/android/javatests/jni/jni_onload.cc:1: //
Copyright (c) 2012 The Chromium Authors. All rights reserved.
On 2014/11/05 22:38:49, mnaganov (cr) wrote:
> 2014

Done.

[SeRya, 2014-11-06 19:59:28]

serya@chromium.org changed reviewers:
+ cpu@chromium.org

[SeRya, 2014-11-06 19:59:29]

+cpu for owner's review of dependencies

[SeRya, 2014-11-06 19:59:52]

serya@chromium.org changed reviewers:
+ cpu@chromium.org

[SeRya, 2014-11-09 19:24:03]

serya@chromium.org changed reviewers:
- cpu@chromium.org, glaznev@chromium.org

[SeRya, 2014-11-09 19:27:58]

I temporarily removed dependency on third_part/webrtc/third_party/libjingle
since now I want to add it slightly differently in the next CL
(https://codereview.chromium.org/716433003/).

So dependency owner's LGTM not yet needed.

[SeRya, 2014-11-10 03:28:41]

The CQ bit was checked by serya@chromium.org

[commit-bot: I haz the power, 2014-11-10 03:29:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/704613003/80001

[commit-bot: I haz the power, 2014-11-10 04:15:16]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2014-11-10 04:15:53]

Patchset 4 (id:??) landed as
https://crrev.com/3c76b33f9d02ffc9b386cbbd0351e9957fd8ef66
Cr-Commit-Position: refs/heads/master@{#303421}