Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1217)

Unified Diff: runtime/bin/vmservice/client/lib/src/observatory_elements/instance_ref.dart

Issue 98253009: Refactor VM service IDs (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice/client/lib/src/observatory_elements/instance_ref.dart
diff --git a/runtime/bin/vmservice/client/lib/src/observatory_elements/instance_ref.dart b/runtime/bin/vmservice/client/lib/src/observatory_elements/instance_ref.dart
index 3e8aa78337ce369644a475fff09adc9fe5e88c26..7f5368fde62ea5962fb73b7cacb33c3134887d4e 100644
--- a/runtime/bin/vmservice/client/lib/src/observatory_elements/instance_ref.dart
+++ b/runtime/bin/vmservice/client/lib/src/observatory_elements/instance_ref.dart
@@ -5,10 +5,16 @@
library instance_ref_element;
import 'package:polymer/polymer.dart';
-import 'observatory_element.dart';
+import 'service_ref.dart';
@CustomTag('instance-ref')
-class InstanceRefElement extends ObservatoryElement {
- @published Map instance;
+class InstanceRefElement extends ServiceRefElement {
InstanceRefElement.created() : super.created();
+
+ String get name {
+ if (ref == null) {
+ return super.name;
turnidge 2013/12/19 20:39:29 What's this doing? Can this go away after class-v
Cutch 2013/12/19 21:53:58 ServiceRefElement provides a default implementatio
+ }
+ return ref['preview'];
+ }
}

Powered by Google App Engine
This is Rietveld 408576698