runtime/bin/vmservice/client/lib/src/observatory_elements/instance_view.html - Issue 98253009: Refactor VM service IDs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice/client/lib/src/observatory_elements/instance_view.html

Issue 98253009: Refactor VM service IDs (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« runtime/bin/vmservice/client/lib/src/observatory_elements/instance_ref.dart ('K') | « runtime/bin/vmservice/client/lib/src/observatory_elements/instance_ref.html ('k') | runtime/bin/vmservice/client/lib/src/observatory_elements/isolate_summary.dart » ('j') | runtime/bin/vmservice/client/lib/src/observatory_elements/library_view.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/bin/vmservice/client/lib/src/observatory_elements/instance_view.html

diff --git a/runtime/bin/vmservice/client/lib/src/observatory_elements/instance_view.html b/runtime/bin/vmservice/client/lib/src/observatory_elements/instance_view.html

index c4864c4fe4f6edac7ea38c451ed78feac84e31cc..9bce7e10a4fe7272b90db9caa9feac4aedffda85 100644

--- a/runtime/bin/vmservice/client/lib/src/observatory_elements/instance_view.html

+++ b/runtime/bin/vmservice/client/lib/src/observatory_elements/instance_view.html

@@ -1,4 +1,5 @@

<head>

+ <link rel="import" href="class_ref.html">

@@ -8,12 +9,10 @@

- <div class="panel panel-warning">

+ <div class="panel panel-warning">

Instance of

- <a href="{{ app.locationManager.currentIsolateClassLink(instance['class']['id'])}}">

- {{ instance['class']['user_name'] }}

- </a>

+ <class-ref app="{{ app }}" ref="{{ instance['class'] }}"></class-ref>

</div>

@@ -29,7 +28,7 @@

<tbody>

- <td><instance-ref app="{{ app }}" instance="{{ field['value'] }}"></instance-ref></td>

+ <td><instance-ref app="{{ app }}" instance="{{ field['value'] }}"></instance-ref></td>

turnidge 2013/12/19 20:39:29 instance= & field= seems suspicious here.

</tr>

</tbody>

</table>