Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 981733009: Fix all dartanalyzer errors in dart:sky except the Native ones. (Closed)

Created:
5 years, 9 months ago by eseidel
Modified:
5 years, 9 months ago
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, rafaelw, yzshen+watch_chromium.org, zra
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Fix all dartanalyzer errors in dart:sky except the Native ones. I also fixed all warnings. :) This is the only error remaining: [error] Native functions can only be declared in the SDK and code that is loaded through native extensions My understanding is that we need to do something similar to: https://codereview.chromium.org/950063002/ in order to work around the 'native' issue. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/14270f1151aacfa650985c4333572c356d15c024

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -18 lines) Patch
M sky/engine/bindings/BUILD.gn View 5 chunks +5 lines, -5 lines 0 comments Download
M sky/engine/bindings/scripts/compiler.py View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/scripts/dart_types.py View 3 chunks +3 lines, -2 lines 0 comments Download
M sky/engine/bindings/scripts/templates/dart_blink.template View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/scripts/templates/interface_dart.template View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/animation/Animation.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/dom/Range.idl View 1 chunk +2 lines, -1 line 0 comments Download
M sky/engine/core/dom/URL.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/events/Event.idl View 1 chunk +3 lines, -1 line 0 comments Download
M sky/engine/core/frame/Window.idl View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/html/canvas/Path2D.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/tools/shelldb View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
eseidel
5 years, 9 months ago (2015-03-05 20:08:56 UTC) #1
abarth-chromium
lgtm
5 years, 9 months ago (2015-03-05 20:42:37 UTC) #2
eseidel
Committed patchset #1 (id:1) manually as 14270f1151aacfa650985c4333572c356d15c024 (presubmit successful).
5 years, 9 months ago (2015-03-05 21:36:52 UTC) #3
jamesr
Teh sky tests are all red on the bots: Regressions: Unexpected timeouts (1) events/custom-event.sky [ ...
5 years, 9 months ago (2015-03-05 22:21:08 UTC) #5
tonyg
5 years, 9 months ago (2015-03-05 23:05:01 UTC) #7
Message was sent while issue was closed.
On 2015/03/05 22:21:08, jamesr wrote:
> Teh sky tests are all red on the bots:
> 
> Regressions: Unexpected timeouts (1)
>   events/custom-event.sky [ Timeout ]
> 
> and I see no tryruns :(

[+jimbe] whose roll is help up on this

Powered by Google App Engine
This is Rietveld 408576698