Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2450)

Unified Diff: sky/engine/core/events/Event.idl

Issue 981733009: Fix all dartanalyzer errors in dart:sky except the Native ones. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/dom/URL.idl ('k') | sky/engine/core/frame/Window.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/events/Event.idl
diff --git a/sky/engine/core/events/Event.idl b/sky/engine/core/events/Event.idl
index d6ab9e9186bd770eeab34f2f53f965c00b972250..9f9c3d100bfe184fc8dc94c985544a84f403bbf5 100644
--- a/sky/engine/core/events/Event.idl
+++ b/sky/engine/core/events/Event.idl
@@ -19,7 +19,9 @@
*/
[
- Constructor(DOMString type, [Named] optional boolean bubbles, [Named] optional boolean cancelable),
+ // TODO(eseidel): Type is optional to appease dart analyzer:
+ // The class 'Event' does not have a default constructor
+ Constructor([Named] optional DOMString type, [Named] optional boolean bubbles, [Named] optional boolean cancelable),
] interface Event {
// DOM PhaseType
const unsigned short NONE = 0;
« no previous file with comments | « sky/engine/core/dom/URL.idl ('k') | sky/engine/core/frame/Window.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698