Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Side by Side Diff: sky/tools/shelldb

Issue 981733009: Fix all dartanalyzer errors in dart:sky except the Native ones. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sky/engine/core/html/canvas/Path2D.idl ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright 2015 The Chromium Authors. All rights reserved. 2 # Copyright 2015 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 from skypy.skyserver import SkyServer 6 from skypy.skyserver import SkyServer
7 import argparse 7 import argparse
8 import json 8 import json
9 import logging 9 import logging
10 import os 10 import os
(...skipping 185 matching lines...) Expand 10 before | Expand all | Expand 10 after
196 analyze_parser.add_argument('app_path', type=str) 196 analyze_parser.add_argument('app_path', type=str)
197 analyze_parser.set_defaults(func=self.run) 197 analyze_parser.set_defaults(func=self.run)
198 198
199 def run(self, args, pids): 199 def run(self, args, pids):
200 ANALYZER_PATH = 'third_party/dart-sdk/dart-sdk/bin/dartanalyzer' 200 ANALYZER_PATH = 'third_party/dart-sdk/dart-sdk/bin/dartanalyzer'
201 201
202 build_dir = os.path.abspath(pids['build_dir']) 202 build_dir = os.path.abspath(pids['build_dir'])
203 bindings_path = os.path.join(build_dir, 'gen/sky/bindings') 203 bindings_path = os.path.join(build_dir, 'gen/sky/bindings')
204 sky_builtin_path = \ 204 sky_builtin_path = \
205 os.path.join(SRC_ROOT, 'sky/engine/bindings/builtin.dart') 205 os.path.join(SRC_ROOT, 'sky/engine/bindings/builtin.dart')
206 sky_core_path = os.path.join(bindings_path, 'sky_core.dart') 206 dart_sky_path = os.path.join(bindings_path, 'dart_sky.dart')
207 mojo_bindings_path = \ 207 mojo_bindings_path = \
208 os.path.join(SRC_ROOT, 'mojo/public/dart/bindings.dart') 208 os.path.join(SRC_ROOT, 'mojo/public/dart/bindings.dart')
209 mojo_core_path = os.path.join(SRC_ROOT, 'mojo/public/dart/core.dart') 209 mojo_core_path = os.path.join(SRC_ROOT, 'mojo/public/dart/core.dart')
210 analyzer_args = [ANALYZER_PATH, 210 analyzer_args = [ANALYZER_PATH,
211 # sky_core.dart does not compile cleanly yet. :( 211 # sky_core.dart does not compile cleanly yet. :(
212 # "--url-mapping=dart:sky,%s" % sky_core_path, 212 # "--url-mapping=dart:sky,%s" % dart_sky_path,
213 "--url-mapping=dart:sky_builtin,%s" % sky_builtin_path, 213 "--url-mapping=dart:sky_builtin,%s" % sky_builtin_path,
214 "--url-mapping=mojo:bindings,%s" % mojo_bindings_path, 214 "--url-mapping=mojo:bindings,%s" % mojo_bindings_path,
215 "--url-mapping=mojo:core,%s" % mojo_core_path, 215 "--url-mapping=mojo:core,%s" % mojo_core_path,
216 args.app_path 216 args.app_path
217 ] 217 ]
218 subprocess.call(analyzer_args) 218 subprocess.call(analyzer_args)
219 219
220 220
221 class SkyShellRunner(object): 221 class SkyShellRunner(object):
222 def main(self): 222 def main(self):
223 logging.basicConfig(level=logging.WARNING) 223 logging.basicConfig(level=logging.WARNING)
224 224
225 parser = argparse.ArgumentParser(description='Sky Shell Runner') 225 parser = argparse.ArgumentParser(description='Sky Shell Runner')
226 subparsers = parser.add_subparsers(help='sub-command help') 226 subparsers = parser.add_subparsers(help='sub-command help')
227 227
228 for command in [StartSky(), StopSky(), Analyze()]: 228 for command in [StartSky(), StopSky(), Analyze()]:
229 command.add_subparser(subparsers) 229 command.add_subparser(subparsers)
230 230
231 args = parser.parse_args() 231 args = parser.parse_args()
232 pids = Pids.read_from(PID_FILE_PATH, PID_FILE_KEYS) 232 pids = Pids.read_from(PID_FILE_PATH, PID_FILE_KEYS)
233 exit_code = args.func(args, pids) 233 exit_code = args.func(args, pids)
234 # We could do this with an at-exit handler instead? 234 # We could do this with an at-exit handler instead?
235 pids.write_to(PID_FILE_PATH) 235 pids.write_to(PID_FILE_PATH)
236 sys.exit(exit_code) 236 sys.exit(exit_code)
237 237
238 238
239 if __name__ == '__main__': 239 if __name__ == '__main__':
240 SkyShellRunner().main() 240 SkyShellRunner().main()
OLDNEW
« no previous file with comments | « sky/engine/core/html/canvas/Path2D.idl ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698