chrome/browser/services/gcm/gcm_profile_service.h - Issue 98173009: GCM Checkin implementation with unit tests and protobufs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/services/gcm/gcm_profile_service.h

Issue 98173009: GCM Checkin implementation with unit tests and protobufs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gcm-store

Patch Set: Renaming fields, class names and files, updating gyp file. Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/services/gcm/gcm_client_mock.h ('K') | « chrome/browser/services/gcm/gcm_client_mock.cc ('k') | chrome/browser/services/gcm/gcm_profile_service.cc » ('j') | chrome/browser/services/gcm/gcm_profile_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/services/gcm/gcm_profile_service.h

diff --git a/chrome/browser/services/gcm/gcm_profile_service.h b/chrome/browser/services/gcm/gcm_profile_service.h

index 258ff8290ca7e9df8b39e834bb874c2c9abbe69f..72cab6d9eee8c5227c0c77a4823177dc2fa43dbc 100644

--- a/chrome/browser/services/gcm/gcm_profile_service.h

+++ b/chrome/browser/services/gcm/gcm_profile_service.h

@@ -50,7 +50,7 @@ class GCMProfileService : public BrowserContextKeyedService,

class TestingDelegate {

public:

virtual GCMEventRouter* GetEventRouter() const = 0;

- virtual void CheckInFinished(const GCMClient::CheckInInfo& checkin_info,

+ virtual void CheckInFinished(const GCMClient::CheckinInfo& checkin_info,

GCMClient::Result result) = 0;

};

@@ -140,7 +140,7 @@ class GCMProfileService : public BrowserContextKeyedService,

const GCMClient::OutgoingMessage& message);

// Callbacks posted from IO thread to UI thread.

- void CheckInFinished(GCMClient::CheckInInfo checkin_info,

+ void CheckInFinished(GCMClient::CheckinInfo checkin_info,

Nicolas Zea 2014/01/07 00:41:52 const ref

fgorski 2014/01/07 23:46:44 Added a TODO.

GCMClient::Result result);

void RegisterFinished(std::string app_id,

std::string registration_id,