GCM Checkin implementation with unit tests and protobufs

chrome/browser/services/gcm/gcm_client_mock.h

Index: chrome/browser/services/gcm/gcm_client_mock.h
diff --git a/chrome/browser/services/gcm/gcm_client_mock.h b/chrome/browser/services/gcm/gcm_client_mock.h
index aeca13a5449c4492ec7337e3d5757f14fbb3977e..005fd88297fd8b2b4a616e19296f6cec69bdd708 100644
--- a/chrome/browser/services/gcm/gcm_client_mock.h
+++ b/chrome/browser/services/gcm/gcm_client_mock.h
@@ -47,7 +47,7 @@ class GCMClientMock : public GCMClient {
 
   void SetIsLoading(bool is_loading);
 
-  static CheckInInfo GetCheckInInfoFromUsername(const std::string& username);
+  static CheckinInfo GetCheckinInfoFromUsername(const std::string& username);
   static std::string GetRegistrationIdFromSenderIds(
       const std::vector<std::string>& sender_ids);
 
@@ -55,7 +55,7 @@ class GCMClientMock : public GCMClient {
   Delegate* GetDelegate(const std::string& username) const;
 
   // Called on IO thread.
-  void CheckInFinished(std::string username, CheckInInfo checkin_info);
+  void CheckInFinished(std::string username, CheckinInfo checkin_info);

[Nicolas Zea, 2014/01/07 00:41:52]

nit: this, and all these other params should be passed by const ref. I should
have caught that the first time around.

[fgorski, 2014/01/07 23:46:44]

Added a TODO

   void RegisterFinished(std::string username,
                         std::string app_id,
                         std::string registrion_id);