GCM Checkin implementation with unit tests and protobufs

chrome/browser/services/gcm/gcm_profile_service.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SERVICES_GCM_GCM_PROFILE_SERVICE_H_
 #define CHROME_BROWSER_SERVICES_GCM_GCM_PROFILE_SERVICE_H_
 
 #include <map>
 
 #include "base/basictypes.h"
@@ skipping 32 matching lines @@
  public:
   typedef base::Callback<void(const std::string& registration_id,
                               GCMClient::Result result)> RegisterCallback;
   typedef base::Callback<void(const std::string& message_id,
                               GCMClient::Result result)> SendCallback;
 
   // For testing purpose.
   class TestingDelegate {
    public:
     virtual GCMEventRouter* GetEventRouter() const = 0;
-    virtual void CheckInFinished(const GCMClient::CheckInInfo& checkin_info,
+    virtual void CheckInFinished(const GCMClient::CheckinInfo& checkin_info,
                                  GCMClient::Result result) = 0;
   };
 
   // Returns true if the GCM support is enabled.
   static bool IsGCMEnabled();
 
   // Register profile-specific prefs for GCM.
   static void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry);
 
   explicit GCMProfileService(Profile* profile);
@@ skipping 69 matching lines @@
 
   void DoRegister(const std::string& app_id,
                   const std::vector<std::string>& sender_ids,
                   const std::string& cert,
                   RegisterCallback callback);
   void DoSend(const std::string& app_id,
               const std::string& receiver_id,
               const GCMClient::OutgoingMessage& message);
 
   // Callbacks posted from IO thread to UI thread.
-  void CheckInFinished(GCMClient::CheckInInfo checkin_info,
+  void CheckInFinished(GCMClient::CheckinInfo checkin_info,

[Nicolas Zea, 2014/01/07 00:41:52]

const ref

[fgorski, 2014/01/07 23:46:44]

Added a TODO.

                        GCMClient::Result result);
   void RegisterFinished(std::string app_id,
                         std::string registration_id,
                         GCMClient::Result result);
   void SendFinished(std::string app_id,
                     std::string message_id,
                     GCMClient::Result result);
   void MessageReceived(std::string app_id,
                        GCMClient::IncomingMessage message);
   void MessagesDeleted(std::string app_id);
@@ skipping 50 matching lines @@
 
   // Used to pass a weak pointer to the IO worker.
   base::WeakPtrFactory<GCMProfileService> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(GCMProfileService);
 };
 
 }  // namespace gcm
 
 #endif  // CHROME_BROWSER_SERVICES_GCM_GCM_PROFILE_SERVICE_H_