GCM Checkin implementation with unit tests and protobufs

chrome/browser/services/gcm/gcm_client_mock.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SERVICES_GCM_GCM_CLIENT_MOCK_H_
 #define CHROME_BROWSER_SERVICES_GCM_GCM_CLIENT_MOCK_H_
 
 #include <map>
 
 #include "base/compiler_specific.h"
@@ skipping 29 matching lines @@
                       const std::string& app_id,
                       const IncomingMessage& message);
   void DeleteMessages(const std::string& username, const std::string& app_id);
 
   void set_simulate_server_error(bool simulate_server_error) {
     simulate_server_error_ = simulate_server_error;
   }
 
   void SetIsLoading(bool is_loading);
 
-  static CheckInInfo GetCheckInInfoFromUsername(const std::string& username);
+  static CheckinInfo GetCheckinInfoFromUsername(const std::string& username);
   static std::string GetRegistrationIdFromSenderIds(
       const std::vector<std::string>& sender_ids);
 
  private:
   Delegate* GetDelegate(const std::string& username) const;
 
   // Called on IO thread.
-  void CheckInFinished(std::string username, CheckInInfo checkin_info);
+  void CheckInFinished(std::string username, CheckinInfo checkin_info);

[Nicolas Zea, 2014/01/07 00:41:52]

nit: this, and all these other params should be passed by const ref. I should
have caught that the first time around.

[fgorski, 2014/01/07 23:46:44]

Added a TODO

   void RegisterFinished(std::string username,
                         std::string app_id,
                         std::string registrion_id);
   void SendFinished(std::string username,
                     std::string app_id,
                     std::string message_id);
   void MessageReceived(std::string username,
                        std::string app_id,
                        IncomingMessage message);
   void MessagesDeleted(std::string username, std::string app_id);
   void MessageSendError(std::string username,
                         std::string app_id,
                         std::string message_id);
   void LoadingCompleted();
 
   std::map<std::string, Delegate*> delegates_;
 
   bool is_loading_;
 
   // The testing code could set this to simulate the server error in order to
   // test the error scenario.
   bool simulate_server_error_;
 
   DISALLOW_COPY_AND_ASSIGN(GCMClientMock);
 };
 
 }  // namespace gcm
 
 #endif  // CHROME_BROWSER_SERVICES_GCM_GCM_CLIENT_MOCK_H_