Fix Ozone ECS bot

Fix Ozone ECS bot

BUG=none
TBR=brettw@chromium.org

Committed: https://crrev.com/51c423508043d9f31862c84576a084d79db3da9f
Cr-Commit-Position: refs/heads/master@{#319445}

[dnicoara, 2015-03-05 20:32:39]

dnicoara@chromium.org changed reviewers:
+ brettw@chromium.org, dpranke@chromium.org

[dnicoara, 2015-03-05 20:32:40]

https://codereview.chromium.org/977703003 broke the Ozone ECS bot (since the ECS
bot build the bare minimum to get the content_shell target working).

See
http://build.chromium.org/p/chromium.fyi/builders/Ozone%20ECS%20Linux/builds/...
for breakage details.

[Dirk Pranke, 2015-03-05 21:25:38]

lgtm, thanks for cleaning this up!

[dnicoara, 2015-03-06 04:08:37]

The CQ bit was checked by dnicoara@chromium.org

[commit-bot: I haz the power, 2015-03-06 04:09:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/981023002/20001

[commit-bot: I haz the power, 2015-03-06 04:27:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-06 04:27:12]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dnicoara, 2015-03-06 14:48:09]

TBR-ing brettw@ to get the bot green again.

[dnicoara, 2015-03-06 14:48:12]

The CQ bit was checked by dnicoara@chromium.org

[commit-bot: I haz the power, 2015-03-06 14:49:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/981023002/20001

[commit-bot: I haz the power, 2015-03-06 14:52:09]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-06 14:52:38]

Patchset 2 (id:??) landed as
https://crrev.com/51c423508043d9f31862c84576a084d79db3da9f
Cr-Commit-Position: refs/heads/master@{#319445}

[brettw, 2015-03-06 17:31:00]

lgtm

[Nico, 2015-07-06 23:35:28]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2015-07-06 23:35:29]

https://codereview.chromium.org/981023002/diff/20001/build/gn_migration.gypi
File build/gn_migration.gypi (right):

https://codereview.chromium.org/981023002/diff/20001/build/gn_migration.gypi#...
build/gn_migration.gypi:430: ['chromeos== 1 or use_ash==1', {
Are you sure you want "or" here? Everything else using session_manager_component
seems to be testing for chromeos.

[Nico, 2015-07-06 23:41:05]

https://codereview.chromium.org/981023002/diff/20001/build/gn_migration.gypi
File build/gn_migration.gypi (right):

https://codereview.chromium.org/981023002/diff/20001/build/gn_migration.gypi#...
build/gn_migration.gypi:430: ['chromeos== 1 or use_ash==1', {
On 2015/07/06 23:35:28, Nico wrote:
> Are you sure you want "or" here? Everything else using
session_manager_component
> seems to be testing for chromeos.

https://code.google.com/p/chromium/codesearch#chromium/src/components/compone...
seems to use this condition too though.

Looks like session_manager (accidentally?) isn't part of the gn build.

[Nico, 2015-07-06 23:42:26]

https://codereview.chromium.org/981023002/diff/20001/build/gn_migration.gypi
File build/gn_migration.gypi (right):

https://codereview.chromium.org/981023002/diff/20001/build/gn_migration.gypi#...
build/gn_migration.gypi:430: ['chromeos== 1 or use_ash==1', {
On 2015/07/06 23:41:04, Nico wrote:
> On 2015/07/06 23:35:28, Nico wrote:
> > Are you sure you want "or" here? Everything else using
> session_manager_component
> > seems to be testing for chromeos.
> 
>
https://code.google.com/p/chromium/codesearch#chromium/src/components/compone...
> seems to use this condition too though.
> 
> Looks like session_manager (accidentally?) isn't part of the gn build.

Actually actually, looks like this is in an is_linux block in gn, but not in
gyp: https://code.google.com/p/chromium/codesearch#chromium/src/BUILD.gn&l=324

I guess this should be linux-only in gyp too?