Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 977703003: Re-land the 'gn_migration.gyp' patch. (Closed)

Created:
5 years, 9 months ago by Dirk Pranke
Modified:
5 years, 9 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-land the 'gn_migration.gyp' patch. This patch re-lands the original change plus the fixes I had to introduce the 'gn_all' and 'gyp_remaining' targets in the GYP build. This patch is thus reverting 378e940e (#318636). The code was actually correct at #318636 but was failing on the iOS bots due to problems w/ their recipes that have since been fixed. TBR=brettw@chromium.org BUG=461019 Committed: https://crrev.com/5b90c6fdbd3097080752fcf15f2f0e5ae4d3aec3 Cr-Commit-Position: refs/heads/master@{#318960}

Patch Set 1 #

Patch Set 2 : whoops; fix typos in condition #

Unified diffs Side-by-side diffs Delta from patch set Stats (+508 lines, -150 lines) Patch
M build/all.gyp View 1 2 chunks +6 lines, -150 lines 0 comments Download
A build/gn_migration.gypi View 1 chunk +502 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Dirk Pranke
5 years, 9 months ago (2015-03-03 21:09:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/977703003/1
5 years, 9 months ago (2015-03-03 21:10:51 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/1713) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 9 months ago (2015-03-03 21:16:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/977703003/20001
5 years, 9 months ago (2015-03-03 21:21:00 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-03 23:20:38 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 23:23:22 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5b90c6fdbd3097080752fcf15f2f0e5ae4d3aec3
Cr-Commit-Position: refs/heads/master@{#318960}

Powered by Google App Engine
This is Rietveld 408576698