Fix Ozone ECS bot

build/gn_migration.gypi

 # Copyright (c) 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # This file defines three targets that we are using to
 # track the progress of the GYP->GN migration:
 #
 # If you run 'ninja gn_build gyp_remaining gyp_groups', and then
 # run 'ninja', the second ninja invocation should do nothing. This
 # indicates that everything built by a ninja build is in fact
@@ skipping 347 matching lines @@
             '../chrome/chrome.gyp:chrome_app_unittests',
             '../chrome/chrome.gyp:chromedriver',
             '../chrome/chrome.gyp:chromedriver_tests',
             '../chrome/chrome.gyp:chromedriver_unittests',
             '../chrome/chrome.gyp:load_library_perf_tests',
             '../chrome/chrome.gyp:performance_browser_tests',
             '../chrome/chrome.gyp:service_discovery_sniffer',
             '../cloud_print/cloud_print.gyp:cloud_print_unittests',
             '../components/components.gyp:network_hints_browser',
             '../components/components.gyp:policy_templates',
-            '../components/components.gyp:session_manager_component',
             '../components/components_tests.gyp:components_browsertests',
             '../components/components_tests.gyp:components_perftests',
             '../content/content.gyp:content_app_browser',
             '../content/content.gyp:content_app_child',
             '../content/content_shell_and_tests.gyp:content_gl_benchmark',
             '../content/content_shell_and_tests.gyp:content_gl_tests',
             '../courgette/courgette.gyp:courgette',
             '../courgette/courgette.gyp:courgette_fuzz',
             '../dbus/dbus.gyp:dbus_test_server',
             '../device/device_tests.gyp:device_unittests',
             '../gin/gin.gyp:gin_v8_snapshot_fingerprint',
             '../gin/gin.gyp:gin_shell',
             '../google_apis/gcm/gcm.gyp:mcs_probe',
             '../gpu/gpu.gyp:gl_tests',
-            '../gpu/tools/tools.gyp:compositor_model_bench',
             '../gpu/gles2_conform_support/gles2_conform_support.gyp:gles2_conform_support',
             '../gpu/gles2_conform_support/gles2_conform_test.gyp:gles2_conform_test',
             '../gpu/khronos_glcts_support/khronos_glcts_test.gyp:khronos_glcts_test',
             '../media/cast/cast.gyp:cast_benchmarks',
             '../media/cast/cast.gyp:generate_barcode_video',
             '../media/cast/cast.gyp:generate_timecode_audio',
             '../media/cast/cast.gyp:tap_proxy',
-            '../media/media.gyp:player_x11',
             '../mojo/mojo_base.gyp:mojo_application_chromium',
             '../net/net.gyp:hpack_example_generator',
             '../net/net.gyp:hpack_fuzz_mutator',
             '../net/net.gyp:hpack_fuzz_wrapper',
             '../net/net.gyp:net_perftests',
             '../ppapi/ppapi_internal.gyp:ppapi_unittests',
             '../ppapi/tools/ppapi_tools.gyp:pepper_hash_for_uma',
             '../remoting/app_remoting_webapp.gyp:ar_sample_app',
-            '../remoting/remoting.gyp:remoting_host',
-            '../remoting/remoting.gyp:remoting_it2me_native_messaging_host',
-            '../remoting/remoting.gyp:remoting_me2me_host',
-            '../remoting/remoting.gyp:remoting_me2me_native_messaging_host',
-            '../remoting/remoting.gyp:remoting_native_messaging_manifests',
-            '../remoting/remoting.gyp:remoting_perftests',
-            '../remoting/remoting.gyp:remoting_start_host',
-            '../remoting/remoting.gyp:remoting_unittests',
             '../sandbox/sandbox.gyp:sandbox_linux_jni_unittests',
             '../skia/skia.gyp:filter_fuzz_stub',
             '../skia/skia.gyp:image_operations_bench',
             '../sync/sync.gyp:run_sync_testserver',
             '../sync/sync.gyp:sync_endtoend_tests',
             '../sync/tools/sync_tools.gyp:sync_client',
             '../sync/tools/sync_tools.gyp:sync_listen_notifications',
             '../testing/gmock.gyp:gmock_main',
             '../third_party/leveldatabase/leveldatabase.gyp:env_chromium_unittests',
             '../third_party/libphonenumber/libphonenumber.gyp:libphonenumber_unittests',
             '../third_party/libaddressinput/libaddressinput.gyp:libaddressinput_unittests',
             '../third_party/webrtc/tools/tools.gyp:frame_analyzer',
             '../third_party/webrtc/tools/tools.gyp:rgba_to_i420_converter',
             '../tools/gn/gn.gyp:generate_test_gn_data',
             '../tools/perf/clear_system_cache/clear_system_cache.gyp:clear_system_cache',
             #'../tools/telemetry/telemetry.gyp:bitmaptools', TODO(GYP) should this be #host ?
-            '../ui/app_list/app_list.gyp:app_list_demo',
             '../ui/compositor/compositor.gyp:compositor_unittests',
             '../ui/message_center/message_center.gyp:message_center_unittests',
             '../ui/views/examples/examples.gyp:views_examples_with_content_exe',
             '../v8/tools/gyp/v8.gyp:v8_snapshot',
             '../v8/tools/gyp/v8.gyp:postmortem-metadata',
 
             # TODO(GYP) - list all of the examples explicitly.
             '../ppapi/ppapi_internal.gyp:*',
           ],
           'conditions': [
             ['disable_nacl==0 and disable_nacl_untrusted==0', {
               'dependencies': [
                 '../components/nacl.gyp:nacl_loader_unittests',
                 '../mojo/mojo_nacl.gyp:monacl_shell',
                 '../remoting/remoting.gyp:remoting_key_tester',
               ]
             }],
+            ['chromeos== 1 or use_ash==1', {

[Nico, 2015/07/06 23:35:28]

Are you sure you want "or" here? Everything else using session_manager_component
seems to be testing for chromeos.

[Nico, 2015/07/06 23:41:04]

https://code.google.com/p/chromium/codesearch#chromium/src/components/compone...
seems to use this condition too though.

Looks like session_manager (accidentally?) isn't part of the gn build.

[Nico, 2015/07/06 23:42:25]

Actually actually, looks like this is in an is_linux block in gn, but not in
gyp: https://code.google.com/p/chromium/codesearch#chromium/src/BUILD.gn&l=324

I guess this should be linux-only in gyp too?

+              'dependencies': [
+                '../components/components.gyp:session_manager_component',
+              ],
+            }],
+            ['use_x11==1', {
+              'dependencies': [
+                '../gpu/tools/tools.gyp:compositor_model_bench',
+                '../media/media.gyp:player_x11',
+              ],
+            }],
+            ['remoting==1', {
+              'dependencies': [
+                '../remoting/remoting.gyp:remoting_host',
+                '../remoting/remoting.gyp:remoting_it2me_native_messaging_host',
+                '../remoting/remoting.gyp:remoting_me2me_host',
+                '../remoting/remoting.gyp:remoting_me2me_native_messaging_host',
+                '../remoting/remoting.gyp:remoting_native_messaging_manifests',
+                '../remoting/remoting.gyp:remoting_perftests',
+                '../remoting/remoting.gyp:remoting_start_host',
+                '../remoting/remoting.gyp:remoting_unittests',
+              ],
+            }],
+            ['toolkit_views==1', {
+              'dependencies': [
+                '../ui/app_list/app_list.gyp:app_list_demo',
+              ],
+            }],
             ['test_isolation_mode!="noop"', {
               'dependencies': [
-                '../ash/ash.gyp:ash_unittests_run',
                 '../base/base.gyp:base_unittests_run',
                 '../cc/cc_tests.gyp:cc_unittests_run',
                 '../chrome/chrome.gyp:browser_tests_run',
                 '../chrome/chrome.gyp:chrome_run',
                 '../chrome/chrome.gyp:interactive_ui_tests_run',
                 '../chrome/chrome.gyp:sync_integration_tests_run',
                 '../chrome/chrome.gyp:unit_tests_run',
                 '../components/components_tests.gyp:components_browsertests_run',
                 '../components/components_tests.gyp:components_unittests_run',
                 '../content/content_shell_and_tests.gyp:content_browsertests_run',
                 '../content/content_shell_and_tests.gyp:content_unittests_run',
                 '../crypto/crypto.gyp:crypto_unittests_run',
                 '../courgette/courgette.gyp:courgette_unittests_run',
                 '../gpu/gpu.gyp:gpu_unittests_run',
                 '../media/cast/cast.gyp:cast_unittests_run',
                 '../media/media.gyp:media_unittests_run',
                 '../net/net.gyp:net_unittests_run',
                 '../sandbox/sandbox.gyp:sandbox_linux_unittests_run',
                 '../sql/sql.gyp:sql_unittests_run',
                 '../third_party/cacheinvalidation/cacheinvalidation.gyp:cacheinvalidation_unittests_run',
                 '../ui/accessibility/accessibility.gyp:accessibility_unittests_run',
                 '../ui/app_list/app_list.gyp:app_list_unittests_run',
                 '../ui/events/events.gyp:events_unittests_run',
                 '../ui/message_center/message_center.gyp:message_center_unittests_run',
                 '../ui/touch_selection/ui_touch_selection.gyp:ui_touch_selection_unittests_run',
               ],
+              'conditions': [
+                ['use_ash==1', {
+                  'dependencies': [
+                    '../ash/ash.gyp:ash_unittests_run',
+                  ],
+                }],
+              ],
             }],
           ],
         }],
         ['use_aura==1', {
           'dependencies': [
             '../ui/aura/aura.gyp:aura_demo',
             '../ui/aura/aura.gyp:aura_unittests',
           ],
         }],
       ],
@@ skipping 12 matching lines @@
         'chromium_builder_perf',
         'chromium_builder_tests',
         'chromium_builder_webrtc',
         'chromium_gpu_builder',
         'chromium_gpu_debug_builder',
       ],
     },
       ]
 }