Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(773)

Issue 980073005: Move PageTest.ValidatePageSet special-case into profile creator. (Closed)

Created:
5 years, 9 months ago by slamm
Modified:
5 years, 9 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move PageTest.ValidatePageSet special-case into profile creator. PageTest and user_story_runner.Run do not need to touch this method because it only has to do with a profile creator case. BUG=440101 Committed: https://crrev.com/4a1bf1ab11f7e5a59a55aac9f45bc60b81e58b73 Cr-Commit-Position: refs/heads/master@{#319521}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -22 lines) Patch
M tools/perf/measurements/session_restore.py View 1 chunk +0 lines, -14 lines 0 comments Download
M tools/perf/profile_creators/small_profile_creator.py View 1 chunk +10 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/page/page_test.py View 1 chunk +0 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/user_story/user_story_runner.py View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
nednguyen
5 years, 9 months ago (2015-03-06 00:28:23 UTC) #3
erikchen
lgtm
5 years, 9 months ago (2015-03-06 00:47:18 UTC) #4
nednguyen
lgtm if both Erik & Kari are happy
5 years, 9 months ago (2015-03-06 02:23:02 UTC) #5
aiolos (Not reviewing)
On 2015/03/06 02:23:02, nednguyen wrote: > lgtm if both Erik & Kari are happy lgtm
5 years, 9 months ago (2015-03-06 02:25:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/980073005/1
5 years, 9 months ago (2015-03-06 16:53:43 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-06 23:00:52 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-06 23:01:45 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4a1bf1ab11f7e5a59a55aac9f45bc60b81e58b73
Cr-Commit-Position: refs/heads/master@{#319521}

Powered by Google App Engine
This is Rietveld 408576698