tools/telemetry/telemetry/user_story/user_story_runner.py - Issue 980073005: Move PageTest.ValidatePageSet special-case into profile creator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/user_story/user_story_runner.py

Issue 980073005: Move PageTest.ValidatePageSet special-case into profile creator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/user_story/user_story_runner.py

diff --git a/tools/telemetry/telemetry/user_story/user_story_runner.py b/tools/telemetry/telemetry/user_story/user_story_runner.py

index 24255fc4754071aa9d1ebdaa961d831c27081e1e..627066106a8f120c4e39106fcf7993a90274b4fa 100644

--- a/tools/telemetry/telemetry/user_story/user_story_runner.py

+++ b/tools/telemetry/telemetry/user_story/user_story_runner.py

@@ -192,10 +192,6 @@ def Run(test, user_story_set, expectations, finder_options, results,

We "white list" certain exceptions for which the user story runner

can continue running the remaining user stories.

"""

- # TODO(slamm): Remove special-case for PageTest. https://crbug.com/440101

- if isinstance(test, page_test.PageTest):

- test.ValidatePageSet(user_story_set)

# Filter page set based on options.

user_stories = filter(user_story_filter.UserStoryFilter.IsSelected,

user_story_set)

« no previous file with comments | « tools/telemetry/telemetry/page/page_test.py ('k') | no next file » | no next file with comments »