tools/telemetry/telemetry/page/page_test.py - Issue 980073005: Move PageTest.ValidatePageSet special-case into profile creator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/page_test.py

Issue 980073005: Move PageTest.ValidatePageSet special-case into profile creator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/perf/profile_creators/small_profile_creator.py ('k') | tools/telemetry/telemetry/user_story/user_story_runner.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/page/page_test.py

diff --git a/tools/telemetry/telemetry/page/page_test.py b/tools/telemetry/telemetry/page/page_test.py

index a501c2c5f9ced26b4bcd805f8d05cbd8958a1b4e..e94137f9a34e89051b506fadb4a09854eef470e4 100644

--- a/tools/telemetry/telemetry/page/page_test.py

+++ b/tools/telemetry/telemetry/page/page_test.py

@@ -188,10 +188,6 @@ class PageTest(object):

create a new tab for every page, return browser.tabs.New()."""

return browser.tabs[0]

- def ValidatePageSet(self, page_set):

- """Override to examine the page set before the test run. Useful for

- example to validate that the pageset can be used with the test."""

def ValidateAndMeasurePage(self, page, tab, results):

"""Override to check test assertions and perform measurement.

« no previous file with comments | « tools/perf/profile_creators/small_profile_creator.py ('k') | tools/telemetry/telemetry/user_story/user_story_runner.py » ('j') | no next file with comments »