Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 980043003: Telemetry: Explicitly disconnect InspectorBackend. (Closed)

Created:
5 years, 9 months ago by erikchen
Modified:
5 years, 9 months ago
Reviewers:
dtu
CC:
chromium-reviews, yurys, aandrey+blink_chromium.org, telemetry-reviews_chromium.org, pfeldman, devtools-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@telemetry_add_decorator
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Telemetry: Explicitly disconnect InspectorBackend. Previously, the websocket was disconnected in __del__, whose timing was non-deterministic. Now the websocket is disconnected as soon as its owner (typically devtools_client_backend) no longer wants to keep track of it. BUG=461153 Committed: https://crrev.com/4f9ceb2fe2f91bb0af51106919570957cde44fee Cr-Commit-Position: refs/heads/master@{#319775}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -14 lines) Patch
M tools/telemetry/telemetry/core/backends/chrome/ios_browser_finder.py View 1 chunk +6 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_client_backend.py View 2 chunks +7 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py View 1 2 2 chunks +17 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_websocket.py View 5 chunks +20 lines, -9 lines 0 comments Download

Messages

Total messages: 24 (11 generated)
erikchen
dtu: Please review. Note: This CL depends on https://codereview.chromium.org/976223002/, which you should review first.
5 years, 9 months ago (2015-03-05 19:06:10 UTC) #2
dtu
lgtm
5 years, 9 months ago (2015-03-06 19:28:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/980043003/20001
5 years, 9 months ago (2015-03-06 21:34:20 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/65385)
5 years, 9 months ago (2015-03-06 21:46:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/980043003/40001
5 years, 9 months ago (2015-03-06 21:57:04 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) mac_chromium_rel_ng on ...
5 years, 9 months ago (2015-03-06 23:58:16 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/980043003/40001
5 years, 9 months ago (2015-03-07 00:13:17 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) Timed out ...
5 years, 9 months ago (2015-03-07 03:24:51 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/980043003/40001
5 years, 9 months ago (2015-03-09 18:07:43 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) Timed out ...
5 years, 9 months ago (2015-03-09 20:08:59 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/980043003/40001
5 years, 9 months ago (2015-03-09 23:05:10 UTC) #22
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-09 23:53:27 UTC) #23
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 23:54:15 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4f9ceb2fe2f91bb0af51106919570957cde44fee
Cr-Commit-Position: refs/heads/master@{#319775}

Powered by Google App Engine
This is Rietveld 408576698