tools/telemetry/telemetry/core/backends/chrome/ios_browser_finder.py - Issue 980043003: Telemetry: Explicitly disconnect InspectorBackend.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/ios_browser_finder.py

Issue 980043003: Telemetry: Explicitly disconnect InspectorBackend. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@telemetry_add_decorator

Patch Set: Rebase. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/core/backends/chrome/ios_browser_finder.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome/ios_browser_finder.py b/tools/telemetry/telemetry/core/backends/chrome/ios_browser_finder.py

index 771fd5eb1c10583a01c2e1bffdfc4bdfe706ed76..589f20760f25165a1e816906aa13feca039fd745 100644

--- a/tools/telemetry/telemetry/core/backends/chrome/ios_browser_finder.py

+++ b/tools/telemetry/telemetry/core/backends/chrome/ios_browser_finder.py

@@ -100,9 +100,12 @@ def FindAllAvailableBrowsers(finder_options, device):

browser_types = set()

for url in debug_urls:

context = {'webSocketDebuggerUrl': url, 'id': 1}

- inspector = inspector_backend.InspectorBackend(

- backend.app, backend.devtools_client, context)

- res = inspector.EvaluateJavaScript("navigator.userAgent")

+ try:

+ inspector = inspector_backend.InspectorBackend(

+ backend.app, backend.devtools_client, context)

+ res = inspector.EvaluateJavaScript("navigator.userAgent")

+ finally:

+ inspector.Disconnect()

match_browsers = re.search(browser_pattern, res)

if match_browsers:

browser_types.add(match_browsers.group(1))

« no previous file with comments | « no previous file | tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_client_backend.py » ('j') | no next file with comments »