Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_client_backend.py

Issue 980043003: Telemetry: Explicitly disconnect InspectorBackend. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@telemetry_add_decorator
Patch Set: Rebase. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_client_backend.py
diff --git a/tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_client_backend.py b/tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_client_backend.py
index 347bcb6f73ff2b3cf4df2c1b00dfab591abf333c..1be7928fb76f06572adf4f941af62410d213c8af 100644
--- a/tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_client_backend.py
+++ b/tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_client_backend.py
@@ -30,6 +30,11 @@ def _IsDevToolsAgentAvailable(devtools_http_instance):
class DevToolsClientBackend(object):
+ """An object that communicates with Chrome's devtools.
+
+ This class owns a map of InspectorBackends. It is responsible for creating
+ them and destroying them.
+ """
def __init__(self, devtools_port, remote_devtools_port, app_backend):
"""Creates a new DevToolsClientBackend.
@@ -194,6 +199,8 @@ class _DevToolsContextMapBackend(object):
context_ids = [context['id'] for context in contexts]
for context_id in self._inspector_backends_dict.keys():
if context_id not in context_ids:
+ backend = self._inspector_backends_dict[context_id]
+ backend.Disconnect()
del self._inspector_backends_dict[context_id]
valid_contexts = []

Powered by Google App Engine
This is Rietveld 408576698