Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 979813004: Make VoiceSearchTabHelper a purely native object (Closed)

Created:
5 years, 9 months ago by jdduke (slow)
Modified:
5 years, 9 months ago
CC:
chromium-reviews, David Trainor- moved to gerrit, avayvod+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make VoiceSearchTabHelper a purely native object There's no reason for VoiceSearchTabHelper to exist as a Java entity. It simply routes a WebContentsObserver callback originating in native code back to some more native code for processing, and has no Java dependencies. Committed: https://crrev.com/fe9592fc2e2bcfb64ecb22eb2dbcee139a6797e6 Cr-Commit-Position: refs/heads/master@{#319186}

Patch Set 1 #

Patch Set 2 : Fix #

Patch Set 3 : Cleanup #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -60 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/Tab.java View 1 2 3 3 chunks +0 lines, -7 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/VoiceSearchTabHelper.java View 1 2 3 1 chunk +0 lines, -32 lines 0 comments Download
M chrome/browser/android/chrome_jni_registrar.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/android/voice_search_tab_helper.h View 1 2 1 chunk +22 lines, -2 lines 0 comments Download
M chrome/browser/android/voice_search_tab_helper.cc View 1 2 1 chunk +15 lines, -17 lines 0 comments Download
M chrome/browser/ui/tab_helpers.cc View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
jdduke (slow)
dtrainor@: Thoughts?
5 years, 9 months ago (2015-03-04 20:01:27 UTC) #2
David Trainor- moved to gerrit
lgtm
5 years, 9 months ago (2015-03-04 23:13:22 UTC) #3
jdduke (slow)
+pkasting for chrome/browser/ui review.
5 years, 9 months ago (2015-03-04 23:14:57 UTC) #5
Peter Kasting
LGTM; feel free to TBR this sort of purely-mechanical change
5 years, 9 months ago (2015-03-04 23:20:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/979813004/40001
5 years, 9 months ago (2015-03-04 23:25:09 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/47385)
5 years, 9 months ago (2015-03-04 23:46:02 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/979813004/60001
5 years, 9 months ago (2015-03-05 00:14:25 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 9 months ago (2015-03-05 01:12:07 UTC) #14
commit-bot: I haz the power
5 years, 9 months ago (2015-03-05 01:12:55 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/fe9592fc2e2bcfb64ecb22eb2dbcee139a6797e6
Cr-Commit-Position: refs/heads/master@{#319186}

Powered by Google App Engine
This is Rietveld 408576698