Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Side by Side Diff: chrome/browser/android/voice_search_tab_helper.cc

Issue 979813004: Make VoiceSearchTabHelper a purely native object (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/android/voice_search_tab_helper.h ('k') | chrome/browser/ui/tab_helpers.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/voice_search_tab_helper.h" 5 #include "chrome/browser/android/voice_search_tab_helper.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "components/google/core/browser/google_util.h" 8 #include "components/google/core/browser/google_util.h"
9 #include "content/public/browser/render_view_host.h" 9 #include "content/public/browser/render_view_host.h"
10 #include "content/public/browser/web_contents.h" 10 #include "content/public/browser/web_contents.h"
11 #include "content/public/common/content_switches.h" 11 #include "content/public/common/content_switches.h"
12 #include "content/public/common/web_preferences.h" 12 #include "content/public/common/web_preferences.h"
13 #include "jni/VoiceSearchTabHelper_jni.h"
14 13
15 using content::WebContents; 14 DEFINE_WEB_CONTENTS_USER_DATA_KEY(VoiceSearchTabHelper);
16 15
17 // Register native methods 16 VoiceSearchTabHelper::VoiceSearchTabHelper(content::WebContents* contents)
18 bool RegisterVoiceSearchTabHelper(JNIEnv* env) { 17 : content::WebContentsObserver(contents) {
19 return RegisterNativesImpl(env); 18 gesture_requirement_for_playback_disabled_ =
19 base::CommandLine::ForCurrentProcess()->HasSwitch(
20 switches::kDisableGestureRequirementForMediaPlayback);
20 } 21 }
21 22
22 static void UpdateAutoplayStatus(JNIEnv* env, 23 VoiceSearchTabHelper::~VoiceSearchTabHelper() {
23 jobject obj, 24 }
24 jobject j_web_contents) { 25
26 void VoiceSearchTabHelper::NavigationEntryCommitted(
27 const content::LoadCommittedDetails& load_details) {
25 // In the case where media autoplay has been disabled by default (e.g. in 28 // In the case where media autoplay has been disabled by default (e.g. in
26 // performance media tests) do not update it based on navigation changes. 29 // performance media tests) do not update it based on navigation changes.
27 const base::CommandLine& command_line = 30 if (gesture_requirement_for_playback_disabled_)
28 *base::CommandLine::ForCurrentProcess();
29 if (command_line.HasSwitch(
30 switches::kDisableGestureRequirementForMediaPlayback))
31 return; 31 return;
32 32
33 WebContents* web_contents = WebContents::FromJavaWebContents(j_web_contents); 33 content::RenderViewHost* host = web_contents()->GetRenderViewHost();
34 content::RenderViewHost* host = web_contents->GetRenderViewHost();
35 content::WebPreferences prefs = host->GetWebkitPreferences(); 34 content::WebPreferences prefs = host->GetWebkitPreferences();
36 35
37 bool gesture_required = 36 bool gesture_required =
38 !google_util::IsGoogleSearchUrl(web_contents->GetLastCommittedURL()); 37 !google_util::IsGoogleSearchUrl(web_contents()->GetLastCommittedURL());
39 38
40 if (gesture_required != prefs.user_gesture_required_for_media_playback) { 39 if (gesture_required != prefs.user_gesture_required_for_media_playback) {
41 // TODO(chrishtr): this is wrong. user_gesture_required_for_media_playback 40 // TODO(chrishtr): this is wrong. user_gesture_required_for_media_playback
42 // will be reset the next time a preference changes. 41 // will be reset the next time a preference changes.
43 prefs.user_gesture_required_for_media_playback = 42 prefs.user_gesture_required_for_media_playback = gesture_required;
44 !google_util::IsGoogleSearchUrl(web_contents->GetLastCommittedURL());
45 host->UpdateWebkitPreferences(prefs); 43 host->UpdateWebkitPreferences(prefs);
46 } 44 }
47 } 45 }
OLDNEW
« no previous file with comments | « chrome/browser/android/voice_search_tab_helper.h ('k') | chrome/browser/ui/tab_helpers.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698