Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/Tab.java

Issue 979813004: Make VoiceSearchTabHelper a purely native object (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/VoiceSearchTabHelper.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/Tab.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/Tab.java b/chrome/android/java/src/org/chromium/chrome/browser/Tab.java
index cf04a0de78b146efd315524eb3979f62777cf99b..fbe2134ad62b6bccb86a69f3eeefeeb738a2a50c 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/Tab.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/Tab.java
@@ -166,7 +166,6 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,
// Content layer Observers and Delegates
private ContentViewClient mContentViewClient;
private WebContentsObserver mWebContentsObserver;
- private VoiceSearchTabHelper mVoiceSearchTabHelper;
private TabChromeWebContentsDelegateAndroid mWebContentsDelegate;
private DomDistillerFeedbackReporter mDomDistillerFeedbackReporter;
@@ -1437,7 +1436,6 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,
mWebContentsDelegate = createWebContentsDelegate();
mWebContentsObserver = new TabWebContentsObserver(mContentViewCore.getWebContents());
- mVoiceSearchTabHelper = new VoiceSearchTabHelper(mContentViewCore.getWebContents());
if (mContentViewClient != null) mContentViewCore.setContentViewClient(mContentViewClient);
@@ -1878,11 +1876,6 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,
mWebContentsObserver = null;
}
- if (mVoiceSearchTabHelper != null) {
- mVoiceSearchTabHelper.destroy();
- mVoiceSearchTabHelper = null;
- }
-
assert mNativeTabAndroid != 0;
nativeDestroyWebContents(mNativeTabAndroid, deleteNativeWebContents);
}
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/VoiceSearchTabHelper.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698