Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 979003003: Only reference constant root list entries in the snapshot. (Closed)

Created:
5 years, 9 months ago by Yang
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Only reference constant root list entries in the snapshot. R=hpayer@chromium.org Committed: https://crrev.com/e571065c14685efd221d0b49febf6f47833448e5 Cr-Commit-Position: refs/heads/master@{#27031}

Patch Set 1 #

Patch Set 2 : omit smis from the root index map #

Patch Set 3 : fixtest #

Patch Set 4 : fix windows build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -27 lines) Patch
M src/arm/macro-assembler-arm.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/heap.h View 1 4 chunks +6 lines, -3 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +25 lines, -22 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/serialize.cc View 1 2 3 1 chunk +6 lines, -2 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-heap.cc View 1 2 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Yang
5 years, 9 months ago (2015-03-05 12:58:35 UTC) #1
Yang
fixtest
5 years, 9 months ago (2015-03-05 13:55:42 UTC) #2
Hannes Payer (out of office)
lgtm
5 years, 9 months ago (2015-03-05 21:17:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/979003003/60001
5 years, 9 months ago (2015-03-05 21:19:56 UTC) #5
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 9 months ago (2015-03-05 21:24:18 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-05 21:24:49 UTC) #7
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/e571065c14685efd221d0b49febf6f47833448e5
Cr-Commit-Position: refs/heads/master@{#27031}

Powered by Google App Engine
This is Rietveld 408576698