src/x64/macro-assembler-x64.cc - Issue 979003003: Only reference constant root list entries in the snapshot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/macro-assembler-x64.cc

Issue 979003003: Only reference constant root list entries in the snapshot. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: fix windows build Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/macro-assembler-x64.cc

diff --git a/src/x64/macro-assembler-x64.cc b/src/x64/macro-assembler-x64.cc

index e4203618fcaa818bdb4441ac3345e3c4d43f0e4f..c5d639755c746ed5e5279017d67912aa7fbf587e 100644

--- a/src/x64/macro-assembler-x64.cc

+++ b/src/x64/macro-assembler-x64.cc

@@ -177,6 +177,7 @@ void MacroAssembler::LoadRootIndexed(Register destination,

void MacroAssembler::StoreRoot(Register source, Heap::RootListIndex index) {

+ DCHECK(Heap::RootCanBeWrittenAfterInitialization(index));

DCHECK(root_array_available_);

movp(Operand(kRootRegister, (index << kPointerSizeLog2) - kRootRegisterBias),

source);

« no previous file with comments | « src/serialize.cc ('k') | test/cctest/test-heap.cc » ('j') | no next file with comments »