src/arm64/macro-assembler-arm64.cc - Issue 979003003: Only reference constant root list entries in the snapshot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm64/macro-assembler-arm64.cc

Issue 979003003: Only reference constant root list entries in the snapshot. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: fix windows build Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/arm64/macro-assembler-arm64.cc

diff --git a/src/arm64/macro-assembler-arm64.cc b/src/arm64/macro-assembler-arm64.cc

index 628c061e43be14ef8a5f5d8cbf2075d64137741f..87bb2966b09796d050ce1a264e1ee3d3fb42f77b 100644

--- a/src/arm64/macro-assembler-arm64.cc

+++ b/src/arm64/macro-assembler-arm64.cc

@@ -1403,6 +1403,7 @@ void MacroAssembler::LoadRoot(CPURegister destination,

void MacroAssembler::StoreRoot(Register source,

Heap::RootListIndex index) {

+ DCHECK(Heap::RootCanBeWrittenAfterInitialization(index));

Str(source, MemOperand(root, index << kPointerSizeLog2));

}

« no previous file with comments | « src/arm/macro-assembler-arm.cc ('k') | src/heap/heap.h » ('j') | no next file with comments »