Changed thread_checker on VideoCaptureImpl and VideoCaptureImplManager.

content/renderer/media/video_capture_impl_manager.h

Index: content/renderer/media/video_capture_impl_manager.h
diff --git a/content/renderer/media/video_capture_impl_manager.h b/content/renderer/media/video_capture_impl_manager.h
index 5bcc7b2a6c3b24215bfcacd2d18cb15807f3a647..3a9a5cd50ab63328cf826393dab4e369e0e0abaa 100644
--- a/content/renderer/media/video_capture_impl_manager.h
+++ b/content/renderer/media/video_capture_impl_manager.h
@@ -39,6 +39,9 @@ namespace content {
 class VideoCaptureImpl;
 class VideoCaptureMessageFilter;
 
+// VideoCaptureImplManager provides access to the representations of capture
+// device in renderer process.
+// All methods must be called on the IO thread.

[mcasas, 2015/03/06 19:18:29]

The docs for the class are, oddly enough, on the beginning of
the file and state, correctly, that this class is created and
operates on Render Main thread (not Render IO thread). 

Please correct in consequence the naming of the member var
below, i.e.

s/io_message_loop_/main_render_message_loop_/

[emircan, 2015/03/10 23:38:36]

Done.

 class CONTENT_EXPORT VideoCaptureImplManager {
  public:
   VideoCaptureImplManager();
@@ -118,8 +121,9 @@ class CONTENT_EXPORT VideoCaptureImplManager {
 
   scoped_refptr<VideoCaptureMessageFilter> filter_;
 
-  // Bound to the render thread.
-  base::ThreadChecker thread_checker_;
+  // Hold a pointer to the IO message loop to check we operate on the right
+  // thread.
+  scoped_refptr<base::MessageLoopProxy> io_message_loop_;

[mcasas, 2015/03/06 19:18:29]

Make const. That way, by reading the class declaration
I can quickly infer that is initialised in the ctor and
not touched anymore.

[emircan, 2015/03/10 23:38:36]

Done.

 
   // Bound to the render thread.
   // NOTE: Weak pointers must be invalidated before all other member variables.