Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Unified Diff: content/renderer/media/video_capture_impl.h

Issue 978993002: Changed thread_checker on VideoCaptureImpl and VideoCaptureImplManager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/video_capture_impl.h
diff --git a/content/renderer/media/video_capture_impl.h b/content/renderer/media/video_capture_impl.h
index d7d6eb0791ed0364cac02bda567e4b4321dbbf1f..21fa91fc305af27621372bceecd472510bb382c3 100644
--- a/content/renderer/media/video_capture_impl.h
+++ b/content/renderer/media/video_capture_impl.h
@@ -45,6 +45,10 @@ class VideoFrame;
namespace content {
+// VideoCaptureImpl is used as a representation of capture device in renderer
+// process. It provides communication to its clients about the state of the
+// capture device.
+// All methods must be called on the IO thread.
mcasas 2015/03/06 19:18:29 Comments for the class are at the file level. Owne
emircan 2015/03/10 23:38:36 I moved the existing comments to here instead.
class CONTENT_EXPORT VideoCaptureImpl
: public VideoCaptureMessageFilter::Delegate {
public:
@@ -173,8 +177,9 @@ class CONTENT_EXPORT VideoCaptureImpl
bool suspended_;
VideoCaptureState state_;
- // |weak_factory_| and |thread_checker_| are bound to the IO thread.
- base::ThreadChecker thread_checker_;
+ // Hold a pointer to the IO message loop to check we operate on the right
+ // thread.
+ scoped_refptr<base::MessageLoopProxy> io_message_loop_;
mcasas 2015/03/06 19:18:29 Make const.
emircan 2015/03/10 23:38:36 This may be overwritten inside Init() method, see
// WeakPtrFactory pointing back to |this| object, for use with
// media::VideoFrames constructed in OnBufferReceived() from buffers cached
« no previous file with comments | « no previous file | content/renderer/media/video_capture_impl.cc » ('j') | content/renderer/media/video_capture_impl_manager.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698