Changed thread_checker on VideoCaptureImpl and VideoCaptureImplManager.

content/renderer/media/video_capture_impl_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // TODO(hclam): This class should be renamed to VideoCaptureService.
 
 // This class provides access to a video capture device in the browser
 // process through IPC. The main function is to deliver video frames
 // to a client.
 //
@@ skipping 21 matching lines @@
 #include "content/common/content_export.h"
 #include "content/common/media/video_capture.h"
 #include "content/public/renderer/media_stream_video_sink.h"
 #include "media/base/video_capture_types.h"
 
 namespace content {
 
 class VideoCaptureImpl;
 class VideoCaptureMessageFilter;
 
+// VideoCaptureImplManager provides access to the representations of capture
+// device in renderer process.
+// All methods must be called on the IO thread.

[mcasas, 2015/03/06 19:18:29]

The docs for the class are, oddly enough, on the beginning of
the file and state, correctly, that this class is created and
operates on Render Main thread (not Render IO thread). 

Please correct in consequence the naming of the member var
below, i.e.

s/io_message_loop_/main_render_message_loop_/

[emircan, 2015/03/10 23:38:36]

Done.

 class CONTENT_EXPORT VideoCaptureImplManager {
  public:
   VideoCaptureImplManager();
   virtual ~VideoCaptureImplManager();
 
   // Open a device associated with the session ID.
   // This method must be called before any methods with the same ID
   // is used.
   // Returns a callback that should be used to release the acquired
   // resources.
@@ skipping 59 matching lines @@
                    std::pair<int, VideoCaptureImpl*> >
       VideoCaptureDeviceMap;
   VideoCaptureDeviceMap devices_;
 
   // This is an internal ID for identifying clients of VideoCaptureImpl.
   // The ID is global for the render process.
   int next_client_id_;
 
   scoped_refptr<VideoCaptureMessageFilter> filter_;
 
-  // Bound to the render thread.
-  base::ThreadChecker thread_checker_;
+  // Hold a pointer to the IO message loop to check we operate on the right
+  // thread.
+  scoped_refptr<base::MessageLoopProxy> io_message_loop_;

[mcasas, 2015/03/06 19:18:29]

Make const. That way, by reading the class declaration
I can quickly infer that is initialised in the ctor and
not touched anymore.

[emircan, 2015/03/10 23:38:36]

Done.

 
   // Bound to the render thread.
   // NOTE: Weak pointers must be invalidated before all other member variables.
   base::WeakPtrFactory<VideoCaptureImplManager> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(VideoCaptureImplManager);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_RENDERER_MEDIA_VIDEO_CAPTURE_IMPL_MANAGER_H_