Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 977533002: cc: Refactored shader locations (Closed)

Created:
5 years, 9 months ago by Lof
Modified:
5 years, 9 months ago
Reviewers:
danakj, enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews, ericrk
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Refactored shader locations This patch is just a small refactor from https://codereview.chromium.org/959283004/ R=danakj, enne Committed: https://crrev.com/5622e563aef622146935d0c3bc26405c5233c521 Cr-Commit-Position: refs/heads/master@{#318946}

Patch Set 1 #

Total comments: 1

Patch Set 2 : add whitespace #

Patch Set 3 : fix chromium-style #

Unified diffs Side-by-side diffs Delta from patch set Stats (+181 lines, -166 lines) Patch
M cc/output/gl_renderer.cc View 1 5 chunks +49 lines, -161 lines 0 comments Download
M cc/output/shader.h View 1 2 11 chunks +29 lines, -5 lines 0 comments Download
M cc/output/shader.cc View 1 2 11 chunks +103 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
Lof
5 years, 9 months ago (2015-03-03 12:46:10 UTC) #1
enne (OOO)
lgtm, thanks for this cleanup! I think this makes GLRenderer a lot easier to read. ...
5 years, 9 months ago (2015-03-03 17:51:02 UTC) #2
danakj
LGTM too, really nice.
5 years, 9 months ago (2015-03-03 18:00:57 UTC) #3
Lof
Done!
5 years, 9 months ago (2015-03-03 18:58:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/977533002/20001
5 years, 9 months ago (2015-03-03 19:04:27 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/65259)
5 years, 9 months ago (2015-03-03 19:32:06 UTC) #11
Lof
fix chromium-style
5 years, 9 months ago (2015-03-03 20:52:50 UTC) #12
enne (OOO)
lgtm
5 years, 9 months ago (2015-03-03 20:56:39 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/977533002/40001
5 years, 9 months ago (2015-03-03 20:57:25 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-03 21:54:36 UTC) #17
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 21:55:13 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5622e563aef622146935d0c3bc26405c5233c521
Cr-Commit-Position: refs/heads/master@{#318946}

Powered by Google App Engine
This is Rietveld 408576698