Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(825)

Unified Diff: Source/core/dom/Node.h

Issue 977113003: Rename renderer() to layoutObject(). (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase to master Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/Node.h
diff --git a/Source/core/dom/Node.h b/Source/core/dom/Node.h
index 914e7b2c4951e590576ee0517a43d6087b11aa1b..ee66465e8a756f957f5889bd396ed357e73cc482 100644
--- a/Source/core/dom/Node.h
+++ b/Source/core/dom/Node.h
@@ -99,7 +99,7 @@ enum StyleChangeType {
class NodeRareDataBase {
public:
- LayoutObject* renderer() const { return m_renderer; }
+ LayoutObject* layoutObject() const { return m_renderer; }
void setRenderer(LayoutObject* renderer) { m_renderer = renderer; }
leviw_travelin_and_unemployed 2015/03/04 20:15:30 Man this is weird :p
dsinclair 2015/03/04 20:37:56 Yea. Doing everything in one CL, I think, would be
protected:
@@ -498,9 +498,9 @@ public:
// -----------------------------------------------------------------------------
// Integration with rendering tree
- // As renderer() includes a branch you should avoid calling it repeatedly in hot code paths.
+ // As layoutObject() includes a branch you should avoid calling it repeatedly in hot code paths.
// Note that if a Node has a renderer, it's parentNode is guaranteed to have one as well.
- LayoutObject* renderer() const { return hasRareData() ? m_data.m_rareData->renderer() : m_data.m_renderer; };
+ LayoutObject* layoutObject() const { return hasRareData() ? m_data.m_rareData->layoutObject() : m_data.m_renderer; };
Julien - ping for review 2015/03/05 16:19:16 It's weird that layoutObject is in rare data.
dsinclair 2015/03/05 16:40:01 crbug.com/464392
void setRenderer(LayoutObject* renderer)
{
if (hasRareData())

Powered by Google App Engine
This is Rietveld 408576698