Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Unified Diff: Source/core/dom/LayoutTreeBuilder.cpp

Issue 977113003: Rename renderer() to layoutObject(). (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase to master Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/LayoutTreeBuilder.cpp
diff --git a/Source/core/dom/LayoutTreeBuilder.cpp b/Source/core/dom/LayoutTreeBuilder.cpp
index 79cd85720a4f0650b37b4260685148ad368f3386..bd17c7871b807fd305e75c5defe4152497fe3948 100644
--- a/Source/core/dom/LayoutTreeBuilder.cpp
+++ b/Source/core/dom/LayoutTreeBuilder.cpp
@@ -51,7 +51,7 @@ LayoutTreeBuilderForElement::LayoutTreeBuilderForElement(Element& element, Layou
if (LayoutObject* nextRenderer = FirstLetterPseudoElement::firstLetterTextRenderer(element))
m_renderingParent = nextRenderer->parent();
} else if (ContainerNode* containerNode = NodeRenderingTraversal::parent(element)) {
- m_renderingParent = containerNode->renderer();
+ m_renderingParent = containerNode->layoutObject();
Julien - ping for review 2015/03/05 16:19:15 We should probably renaming this one too: m_layout
dsinclair 2015/03/05 16:40:01 Done.
}
}
@@ -134,7 +134,7 @@ void LayoutTreeBuilderForElement::createRenderer()
LayoutObject* nextRenderer = this->nextRenderer();
Julien - ping for review 2015/03/05 16:19:15 We need to rename nextRenderer et al., I didn't ca
dsinclair 2015/03/05 16:40:01 Yes, they're on my list to cleanup (along with abo
m_node->setRenderer(newRenderer);
- newRenderer->setStyle(&style); // setStyle() can depend on renderer() already being set.
+ newRenderer->setStyle(&style); // setStyle() can depend on layoutObject() already being set.
Julien - ping for review 2015/03/05 16:19:15 s/newRenderer/newLayoutObject/
if (Fullscreen::isActiveFullScreenElement(*m_node)) {
newRenderer = LayoutFullScreen::wrapRenderer(newRenderer, parentRenderer, &m_node->document());
@@ -142,7 +142,7 @@ void LayoutTreeBuilderForElement::createRenderer()
return;
}
- // Note: Adding newRenderer instead of renderer(). renderer() may be a child of newRenderer.
+ // Note: Adding newRenderer instead of layoutObject(). layoutObject() may be a child of newRenderer.
parentRenderer->addChild(newRenderer, nextRenderer);
}

Powered by Google App Engine
This is Rietveld 408576698