Issue 976003002: Revert "Run dartanalyzer by default."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 976003002: Revert "Run dartanalyzer by default." (Closed)

Created:
5 years, 9 months ago by Elliot Glaysher

Modified:
5 years, 9 months ago

Reviewers:
sky

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Revert "Run dartanalyzer by default." This reverts commit c99022c10494ebe7aaea8a0cf1848dff866af759. It looks like the exact way that we build dart packages requires us to make temporary resolved unzips afterall. > Run dartanalyzer by default. > > This changes the dart_packaged_application() template so that it will > run dartanalyzer on each of the source files, and removes the explicit > dartcheck command from mojob.py. > > On dart null+1 builds, this adds 3 seconds to the build time. There was > no difference in speed on clean -j100 builds. > > BUG=459376 > R=sky@chromium.org > > Review URL: https://codereview.chromium.org/973363002 TBR=sky@chromium.org BUG=459376 Committed: https://chromium.googlesource.com/external/mojo/+/aff73c0c1266f6aff45f3f33aa0b6e5d0c921536

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -1 line)			Patch
M	BUILD.gn	View	1 chunk	+18 lines, -0 lines	0 comments	Download
M	mojo/public/dart/rules.gni	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	mojo/tools/mojob.py	View	2 chunks	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Elliot Glaysher

5 years, 9 months ago (2015-03-04 01:19:50 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
aff73c0c1266f6aff45f3f33aa0b6e5d0c921536 (presubmit successful).

Expand Messages | Collapse Messages