Issue 973363002: Run dartanalyzer by default.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 973363002: Run dartanalyzer by default. (Closed)

Created:
5 years, 9 months ago by Elliot Glaysher

Modified:
5 years, 9 months ago

Reviewers:
sky

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Run dartanalyzer by default. This changes the dart_packaged_application() template so that it will run dartanalyzer on each of the source files, and removes the explicit dartcheck command from mojob.py. On dart null+1 builds, this adds 3 seconds to the build time. There was no difference in speed on clean -j100 builds. BUG=459376 R=sky@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/c99022c10494ebe7aaea8a0cf1848dff866af759

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -33 lines)			Patch
M	BUILD.gn	View	1 chunk	+0 lines, -18 lines	0 comments	Download
M	mojo/public/dart/rules.gni	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	mojo/tools/mojob.py	View	2 chunks	+0 lines, -12 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Elliot Glaysher

5 years, 9 months ago (2015-03-04 00:43:19 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c99022c10494ebe7aaea8a0cf1848dff866af759 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages