mojo/public/dart/rules.gni - Issue 976003002: Revert "Run dartanalyzer by default."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/dart/rules.gni

Issue 976003002: Revert "Run dartanalyzer by default." (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/public/dart/rules.gni

diff --git a/mojo/public/dart/rules.gni b/mojo/public/dart/rules.gni

index c4552ffac582af795fcb7035d43b4ced195a1845..e8d7c7274be59b03a7f21ebfc6465a88281de9cc 100644

--- a/mojo/public/dart/rules.gni

+++ b/mojo/public/dart/rules.gni

@@ -123,7 +123,9 @@ template("dart_packaged_application") {

]

deps = [

- ":$package_analyze_sources",

+ # TODO(erg): When dartanalyze runs at an acceptable speed, add

+ # ":$package_analyze_sources" as a dependency here and remove the

+ # manual group("check") in the toplevel build file.

":$package_name",

]

if (defined(invoker.deps)) {

« no previous file with comments | « BUILD.gn ('k') | mojo/tools/mojob.py » ('j') | no next file with comments »