Revert of Revert of Propagate audible state from player to the containing tab"

Revert of Revert of Propagate audible state from player to the containing tab"

This change contains of two parts. This is Part 1 (Chromium),
Part 2 (Clank) is https://chrome-internal-review.googlesource.com/#/c/204475/

This change reverts https://codereview.chromium.org/972973002/
and restores original https://codereview.chromium.org/896673003/
with an addition of a fix: it removes DCHECK
that verifies that an entry is always found and removed in a map.

An entry will not be in the map unless corresponding player
has been audible at least once.

BUG=414810, 463445
Committed: https://crrev.com/f6f6f6906b091e26b9375b073fcbcbdf4cc5145a
Cr-Commit-Position: refs/heads/master@{#319002}

[Tima Vaisburd, 2015-03-03 23:16:15]

timav@chromium.org changed reviewers:
+ qinmin@chromium.org, sievers@chromium.org, tedchoc@chromium.org

[Tima Vaisburd, 2015-03-03 23:16:16]

Please accept my apology, the original commit has been reverted. This one
contains the fix. Please take a look.

https://codereview.chromium.org/975943003/diff/1/content/browser/android/medi...
File content/browser/android/media_players_observer.cc (right):

https://codereview.chromium.org/975943003/diff/1/content/browser/android/medi...
content/browser/android/media_players_observer.cc:37:
audio_status_map_.erase(Key(rfh, player_id));
The DCHECK was removed from here (see description).

[qinmin, 2015-03-03 23:23:50]

lgtm

[Ted C, 2015-03-03 23:24:38]

lgtm

[Tima Vaisburd, 2015-03-03 23:51:34]

The CQ bit was checked by timav@chromium.org

[commit-bot: I haz the power, 2015-03-03 23:52:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/975943003/1

[commit-bot: I haz the power, 2015-03-04 00:12:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-04 00:12:54]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[no sievers, 2015-03-04 01:03:23]

lgtm

[Tima Vaisburd, 2015-03-04 01:10:05]

The CQ bit was checked by timav@chromium.org

[commit-bot: I haz the power, 2015-03-04 01:11:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/975943003/1

[commit-bot: I haz the power, 2015-03-04 02:19:54]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-03-04 02:20:42]

Patchset 1 (id:??) landed as
https://crrev.com/f6f6f6906b091e26b9375b073fcbcbdf4cc5145a
Cr-Commit-Position: refs/heads/master@{#319002}

[whywhat, 2015-04-24 12:35:46]

avayvod@chromium.org changed reviewers:
+ avayvod@chromium.org

[whywhat, 2015-04-24 12:35:47]

https://codereview.chromium.org/975943003/diff/1/content/browser/android/medi...
File content/browser/android/media_players_observer.h (right):

https://codereview.chromium.org/975943003/diff/1/content/browser/android/medi...
content/browser/android/media_players_observer.h:44: StatusMap
audio_status_map_;
Drive-by: it seems instead of having a map<Key, bool> we could use a set<Key>
(the Key is only present when it's audible) and consider an empty set ==
non-audible WebContents. Has this been considered and if yes, why was it
dropped?

[timav, 2015-04-24 17:56:03]

On 2015/04/24 12:35:47, whywhat wrote:
>
https://codereview.chromium.org/975943003/diff/1/content/browser/android/medi...
> File content/browser/android/media_players_observer.h (right):
> 
>
https://codereview.chromium.org/975943003/diff/1/content/browser/android/medi...
> content/browser/android/media_players_observer.h:44: StatusMap
> audio_status_map_;
> Drive-by: it seems instead of having a map<Key, bool> we could use a set<Key>
> (the Key is only present when it's audible) and consider an empty set ==
> non-audible WebContents. Has this been considered and if yes, why was it
> dropped?

Yes, it seems like a good idea. I think it just hasn't been considered.