media/base/android/media_player_manager.h - Issue 975943003: Revert of Revert of Propagate audible state from player to the containing tab"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/android/media_player_manager.h

Issue 975943003: Revert of Revert of Propagate audible state from player to the containing tab" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/android/media_players_observer.cc ('K') | « media/base/android/media_player_bridge.cc ('k') | media/base/android/media_source_player_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/base/android/media_player_manager.h

diff --git a/media/base/android/media_player_manager.h b/media/base/android/media_player_manager.h

index 58a712f383beb3a9fda231b0b42dbbc99f863871..de23d4fe4f1c7e8defd90c0b9ad5ae7f10c0da69 100644

--- a/media/base/android/media_player_manager.h

+++ b/media/base/android/media_player_manager.h

@@ -63,6 +63,9 @@ class MEDIA_EXPORT MediaPlayerManager {

// Called when video size has changed. Args: player ID, width, height.

virtual void OnVideoSizeChanged(int player_id, int width, int height) = 0;

+ // Called when the player thinks it stopped or started making sound.

+ virtual void OnAudibleStateChanged(int player_id, bool is_audible_now) = 0;

// Returns the player that's in the fullscreen mode currently.

virtual MediaPlayerAndroid* GetFullscreenPlayer() = 0;