Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(918)

Issue 974703003: fix dummy setters -- grammar requires an identifier (Closed)

Created:
5 years, 9 months ago by Jennifer Messerly
Modified:
5 years, 9 months ago
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -10 lines) Patch
M lib/src/codegen/js_codegen.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/js/nodes.dart View 1 1 chunk +4 lines, -1 line 0 comments Download
M test/codegen/expect/_isolate_helper/_isolate_helper.js View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/_native_typed_data/_native_typed_data.js View 1 chunk +2 lines, -2 lines 0 comments Download
M test/codegen/expect/async/async.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/codegen/expect/convert/convert.js View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/fieldtest/fieldtest.js View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/html_input_c/html_input_c.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Jennifer Messerly
@sigmundch -- figured I'd land this so you don't need to include it too. sorry ...
5 years, 9 months ago (2015-03-03 02:27:32 UTC) #2
Jennifer Messerly
went ahead and added asserts too
5 years, 9 months ago (2015-03-03 02:29:32 UTC) #3
vsm
lgtm
5 years, 9 months ago (2015-03-03 13:57:41 UTC) #4
Jennifer Messerly
Committed patchset #2 (id:20001) manually as bd221969fd07eb92a1cffd478ac62ade868824ef (presubmit successful).
5 years, 9 months ago (2015-03-03 14:42:10 UTC) #5
Siggi Cherem (dart-lang)
5 years, 9 months ago (2015-03-03 16:05:59 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698