lib/src/codegen/js_codegen.dart - Issue 974703003: fix dummy setters -- grammar requires an identifier

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/src/codegen/js_codegen.dart

Issue 974703003: fix dummy setters -- grammar requires an identifier (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/src/codegen/js_codegen.dart

diff --git a/lib/src/codegen/js_codegen.dart b/lib/src/codegen/js_codegen.dart

index 628d7a1e95a80bb5c7a80475896653929a4c6611..7b01a65dc99404258fc77145e028573463172e79 100644

--- a/lib/src/codegen/js_codegen.dart

+++ b/lib/src/codegen/js_codegen.dart

@@ -973,7 +973,7 @@ class JSCodegenVisitor extends GeneralizingAstVisitor with ConversionVisitor {

// TODO(jmesserly): use a dummy setter to indicate writable.

if (!node.isFinal) {

methods.add(new JS.Method(

- new JS.PropertyName(name), js.call('function() {}'),

+ new JS.PropertyName(name), js.call('function(_) {}'),

isSetter: true));

}

« no previous file with comments | « no previous file | lib/src/js/nodes.dart » ('j') | no next file with comments »