lib/src/js/nodes.dart - Issue 974703003: fix dummy setters -- grammar requires an identifier

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/src/js/nodes.dart

Issue 974703003: fix dummy setters -- grammar requires an identifier (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/src/js/nodes.dart

diff --git a/lib/src/js/nodes.dart b/lib/src/js/nodes.dart

index 6b574039a77dcffb1589a2f557fb18cb054ec280..394ec7689254bd9ae99e836356c25424790a3341 100644

--- a/lib/src/js/nodes.dart

+++ b/lib/src/js/nodes.dart

@@ -1201,7 +1201,10 @@ class Method extends Property {

Method(Expression name, Fun function,

{this.isGetter: false, this.isSetter: false, this.isStatic: false})

- : super(name, function);

+ : super(name, function) {

+ assert(!isGetter || function.params.length == 0);

+ assert(!isSetter || function.params.length == 1);

+ }

Fun get function => super.value;