Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 974643002: Test and fix SkPMFloat rounding. (Closed)

Created:
5 years, 9 months ago by mtklein_C
Modified:
5 years, 9 months ago
Reviewers:
msarett, mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Test and fix SkPMFloat rounding. SSE rounds for free (that was a happy accident: they also have a truncating version). NEON does not, nor obviously the portable code, so they add 0.5 before truncating. NOPRESUBMIT=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/0aebf5d0d3a2aef38a71885c85303583fdeaad57

Patch Set 1 #

Patch Set 2 : doc #

Patch Set 3 : fix diff #

Patch Set 4 : rebase #

Patch Set 5 : f #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -9 lines) Patch
M src/core/SkPMFloat.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/opts/SkPMFloat_SSE2.h View 2 1 chunk +1 line, -1 line 0 comments Download
M src/opts/SkPMFloat_neon.h View 2 1 chunk +8 lines, -6 lines 0 comments Download
M src/opts/SkPMFloat_none.h View 2 2 chunks +2 lines, -2 lines 0 comments Download
M tests/PMFloatTest.cpp View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
mtklein_C
5 years, 9 months ago (2015-03-03 15:59:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/974643002/60001
5 years, 9 months ago (2015-03-03 16:01:13 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 9 months ago (2015-03-03 16:01:14 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-VS2013-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-VS2013-x86-Debug-Trybot/builds/2786)
5 years, 9 months ago (2015-03-03 16:05:16 UTC) #7
reed1
lgtm
5 years, 9 months ago (2015-03-03 16:21:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/974643002/80001
5 years, 9 months ago (2015-03-03 16:36:09 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 16:57:11 UTC) #12
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/0aebf5d0d3a2aef38a71885c85303583fdeaad57

Powered by Google App Engine
This is Rietveld 408576698