src/opts/SkPMFloat_SSE2.h - Issue 974643002: Test and fix SkPMFloat rounding.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/opts/SkPMFloat_SSE2.h

Issue 974643002: Test and fix SkPMFloat rounding. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: f Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/opts/SkPMFloat_SSE2.h

diff --git a/src/opts/SkPMFloat_SSE2.h b/src/opts/SkPMFloat_SSE2.h

index f28608079f3a4ac9a41a6c4bcc5c941261c4dbf9..908b8baf87c24cbefa9e38e4bbfaeda4c2f9a9c2 100644

--- a/src/opts/SkPMFloat_SSE2.h

+++ b/src/opts/SkPMFloat_SSE2.h

@@ -23,7 +23,7 @@ inline SkPMColor SkPMFloat::get() const {

}

inline SkPMColor SkPMFloat::clamped() const {

- __m128i fix8_32 = _mm_cvtps_epi32(_mm_load_ps(fColor)),

+ __m128i fix8_32 = _mm_cvtps_epi32(_mm_load_ps(fColor)), // _mm_cvtps_epi32 rounds for us!

fix8_16 = _mm_packus_epi16(fix8_32, fix8_32),

fix8 = _mm_packus_epi16(fix8_16, fix8_16);

SkPMColor c = _mm_cvtsi128_si32(fix8);

« no previous file with comments | « src/core/SkPMFloat.h ('k') | src/opts/SkPMFloat_neon.h » ('j') | no next file with comments »