tests/PMFloatTest.cpp - Issue 974643002: Test and fix SkPMFloat rounding.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/PMFloatTest.cpp

Issue 974643002: Test and fix SkPMFloat rounding. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: f Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/PMFloatTest.cpp

diff --git a/tests/PMFloatTest.cpp b/tests/PMFloatTest.cpp

index fceeb47fa127538cbcff0f4521b4ed5f65713974..fbd8626cc813bff944449373d12d31d76fee1e24 100644

--- a/tests/PMFloatTest.cpp

+++ b/tests/PMFloatTest.cpp

@@ -11,7 +11,13 @@ DEF_TEST(SkPMFloat, r) {

REPORTER_ASSERT(r, SkScalarNearlyEqual(204.0f, pmf.r()));

REPORTER_ASSERT(r, SkScalarNearlyEqual(153.0f, pmf.g()));

REPORTER_ASSERT(r, SkScalarNearlyEqual( 51.0f, pmf.b()));

+ REPORTER_ASSERT(r, c == pmf.get());

+ // Test rounding. (Don't bother testing .5... we don't care which way it goes.)

+ pmf.setA(254.6f);

+ pmf.setR(204.3f);

+ pmf.setG(153.1f);

+ pmf.setB( 50.8f);

REPORTER_ASSERT(r, c == pmf.get());

// Test clamping.

« no previous file with comments | « src/opts/SkPMFloat_none.h ('k') | no next file » | no next file with comments »