Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(712)

Issue 974633002: Hotlist Slow: Remove extra thread pool created by VolumeMountWatcherWin. (Closed)

Created:
5 years, 9 months ago by tommycli
Modified:
5 years, 9 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Hotlist Slow: Remove extra thread pool created by VolumeMountWatcherWin. BUG=458541 Committed: https://crrev.com/385e394071526ea23c76b12bf9b901315f562c97 Cr-Commit-Position: refs/heads/master@{#318936}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 2

Patch Set 5 : fix const char #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -33 lines) Patch
M components/storage_monitor/storage_monitor_win_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/storage_monitor/test_volume_mount_watcher_win.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M components/storage_monitor/test_volume_mount_watcher_win.cc View 1 2 3 3 chunks +2 lines, -5 lines 0 comments Download
M components/storage_monitor/volume_mount_watcher_win.h View 2 chunks +2 lines, -6 lines 0 comments Download
M components/storage_monitor/volume_mount_watcher_win.cc View 1 2 3 4 6 chunks +12 lines, -17 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
tommycli
thestig: ptal. Thanks!
5 years, 9 months ago (2015-03-03 18:47:29 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/974633002/diff/60001/components/storage_monitor/volume_mount_watcher_win.cc File components/storage_monitor/volume_mount_watcher_win.cc (right): https://codereview.chromium.org/974633002/diff/60001/components/storage_monitor/volume_mount_watcher_win.cc#newcode37 components/storage_monitor/volume_mount_watcher_win.cc:37: const char* kDeviceInfoTaskRunnerName = "device-info-task-runner"; const char foo[]
5 years, 9 months ago (2015-03-03 19:23:50 UTC) #3
tommycli
https://codereview.chromium.org/974633002/diff/60001/components/storage_monitor/volume_mount_watcher_win.cc File components/storage_monitor/volume_mount_watcher_win.cc (right): https://codereview.chromium.org/974633002/diff/60001/components/storage_monitor/volume_mount_watcher_win.cc#newcode37 components/storage_monitor/volume_mount_watcher_win.cc:37: const char* kDeviceInfoTaskRunnerName = "device-info-task-runner"; On 2015/03/03 19:23:50, Lei ...
5 years, 9 months ago (2015-03-03 19:31:37 UTC) #4
tommycli
thestig: thanks!
5 years, 9 months ago (2015-03-03 19:31:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/974633002/80001
5 years, 9 months ago (2015-03-03 19:33:29 UTC) #8
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 9 months ago (2015-03-03 20:41:13 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 20:42:22 UTC) #10
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/385e394071526ea23c76b12bf9b901315f562c97
Cr-Commit-Position: refs/heads/master@{#318936}

Powered by Google App Engine
This is Rietveld 408576698