components/storage_monitor/test_volume_mount_watcher_win.h - Issue 974633002: Hotlist Slow: Remove extra thread pool created by VolumeMountWatcherWin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/storage_monitor/test_volume_mount_watcher_win.h

Issue 974633002: Hotlist Slow: Remove extra thread pool created by VolumeMountWatcherWin. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix const char Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/storage_monitor/storage_monitor_win_unittest.cc ('k') | components/storage_monitor/test_volume_mount_watcher_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/storage_monitor/test_volume_mount_watcher_win.h

diff --git a/components/storage_monitor/test_volume_mount_watcher_win.h b/components/storage_monitor/test_volume_mount_watcher_win.h

index 267d096078058d3828c4c45675f38f3348568487..5191997f512131f0bb1b0b80fcad695b1c746df6 100644

--- a/components/storage_monitor/test_volume_mount_watcher_win.h

+++ b/components/storage_monitor/test_volume_mount_watcher_win.h

@@ -53,10 +53,6 @@ class TestVolumeMountWatcherWin : public VolumeMountWatcherWin {

virtual GetDeviceDetailsCallbackType

GetDeviceDetailsCallback() const override;

- // Should be used by unit tests to make sure the worker pool doesn't survive

- // into other test runs.

- void ShutdownWorkerPool();

private:

std::vector<base::FilePath> devices_checked_;

scoped_ptr<base::WaitableEvent> device_check_complete_event_;