Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(856)

Unified Diff: components/storage_monitor/volume_mount_watcher_win.h

Issue 974633002: Hotlist Slow: Remove extra thread pool created by VolumeMountWatcherWin. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix const char Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/storage_monitor/volume_mount_watcher_win.h
diff --git a/components/storage_monitor/volume_mount_watcher_win.h b/components/storage_monitor/volume_mount_watcher_win.h
index 48f3741628786f568a43fb20a49bd7a95dc033db..bf351db6ea5c606747b736a33f6ec742b91846ea 100644
--- a/components/storage_monitor/volume_mount_watcher_win.h
+++ b/components/storage_monitor/volume_mount_watcher_win.h
@@ -16,7 +16,6 @@
#include "base/memory/weak_ptr.h"
#include "base/sequenced_task_runner.h"
#include "base/strings/string16.h"
-#include "base/threading/sequenced_worker_pool.h"
#include "components/storage_monitor/storage_info.h"
#include "components/storage_monitor/storage_monitor.h"
@@ -90,11 +89,8 @@ class VolumeMountWatcherWin {
virtual GetAttachedDevicesCallbackType GetAttachedDevicesCallback() const;
virtual GetDeviceDetailsCallbackType GetDeviceDetailsCallback() const;
- // Worker pool used to collect device information. Used because some
- // devices freeze workers trying to get device info, resulting in
- // shutdown hangs.
- scoped_refptr<base::SequencedWorkerPool> device_info_worker_pool_;
- scoped_refptr<base::SequencedTaskRunner> task_runner_;
+ // Used for device info calls that may take a long time.
+ scoped_refptr<base::SequencedTaskRunner> device_info_task_runner_;
private:
friend class TestVolumeMountWatcherWin;
« no previous file with comments | « components/storage_monitor/test_volume_mount_watcher_win.cc ('k') | components/storage_monitor/volume_mount_watcher_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698